Feature/multiple direct likelihood#94
Merged
adolgert merged 9 commits intodev/sample-contextfrom Oct 21, 2025
Merged
Conversation
Owner
adolgert
commented
Oct 21, 2025
- Major Refactoring (15 files changed, +581/-290 lines):
- New file: src/sampler_builder.jl - Extracted sampler building logic from context.jl into a dedicated module
- Context interface overhaul (src/context.jl):
- Context now stores and manages time internally
- Changed enable! to accept relative times instead of absolute times
- Simplified interface by removing explicit when parameters where context tracks time
- Made SamplingContext mutable to track state
- Multiple Direct Method Enhancements (src/sample/multiple_direct.jl):
- Added trajectory likelihood support to MultipleDirect sampler
- Added steploglikelihood() and trajectoryloglikelihood() functions
- Fixed method signature issues
- Made it a proper SSA{K,Time} subtype
- Direct Method Updates (src/sample/direct.jl):
- Fixed trajectoryloglikelihood() to accept an end time parameter
- Improved likelihood calculation logic
- Testing Infrastructure:
- New test file: test/erlang_loss.jl (183 lines) - Erlang loss system simulation for testing
- New test file: test/test_direct.jl (44 lines)
- New test file: test/test_sampler_builder.jl (45 lines)
- Updated existing tests to work with new context interface
- Bug Fixes:
- Removed debug statements
- Fixed getindex function for prefix search
- Minor fixes to trajectory tracking
…es relative enabling time
…hing on the binary tree to save rates
…g the last fire time
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/sample-context #94 +/- ##
======================================================
- Coverage 72.05% 70.97% -1.09%
======================================================
Files 21 22 +1
Lines 1045 1075 +30
======================================================
+ Hits 753 763 +10
- Misses 292 312 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.