Skip to content

Commit 459937f

Browse files
committed
refactor!: remove onHttpServerMessage logic
1 parent d5e8cfe commit 459937f

File tree

2 files changed

+0
-92
lines changed

2 files changed

+0
-92
lines changed

src/dev_server.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,6 @@ export class DevServer {
178178
})
179179

180180
this.#httpServer.on('message', async (message) => {
181-
this.#hooks.onHttpServerMessage(hooksArgs, message, {
182-
restartServer: () => this.#restartHTTPServer(port),
183-
})
184-
185181
/**
186182
* Handle Hot-Hook messages
187183
*/

tests/dev_server.spec.ts

Lines changed: 0 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -127,94 +127,6 @@ test.group('DevServer', () => {
127127
cleanup(() => devServer.close())
128128
})
129129

130-
test('onHttpServerMessage hook should be executed', async ({ assert, fs, cleanup }) => {
131-
let receivedMessages: any[] = []
132-
133-
await fs.createJson('tsconfig.json', {
134-
include: ['**/*'],
135-
exclude: [],
136-
})
137-
await fs.create(
138-
'bin/server.js',
139-
`
140-
process.send({ isAdonisJS: true, environment: 'web' });
141-
process.send({ type: 'http-server-message', message: 'hello' });
142-
`
143-
)
144-
await fs.create('.env', 'PORT=3334')
145-
146-
const devServer = new DevServer(fs.baseUrl, {
147-
assets: { enabled: false },
148-
nodeArgs: [],
149-
scriptArgs: [],
150-
hooks: {
151-
onHttpServerMessage: [
152-
async () => ({
153-
default: (_, message, __) => {
154-
receivedMessages.push(message)
155-
},
156-
}),
157-
],
158-
},
159-
})
160-
161-
await devServer.startAndWatch(ts)
162-
cleanup(() => devServer.close())
163-
164-
await sleep(500)
165-
166-
assert.deepEqual(receivedMessages, [
167-
{ isAdonisJS: true, environment: 'web' },
168-
{ type: 'http-server-message', message: 'hello' },
169-
])
170-
})
171-
172-
test('can restart server from onHttpServerMessage hook', async ({ assert, fs, cleanup }) => {
173-
let receivedMessages: any[] = []
174-
175-
await fs.createJson('tsconfig.json', {
176-
include: ['**/*'],
177-
exclude: [],
178-
})
179-
await fs.create(
180-
'bin/server.js',
181-
`
182-
process.send({ isAdonisJS: true, environment: 'web' });
183-
process.send({ type: 'restart' });
184-
`
185-
)
186-
await fs.create('.env', 'PORT=3334')
187-
188-
let wasRestarted = false
189-
190-
const devServer = new DevServer(fs.baseUrl, {
191-
assets: { enabled: false },
192-
nodeArgs: [],
193-
scriptArgs: [],
194-
hooks: {
195-
onHttpServerMessage: [
196-
async () => ({
197-
default: (_, message, { restartServer }) => {
198-
receivedMessages.push(message)
199-
200-
if (message.type === 'restart' && !wasRestarted) {
201-
restartServer()
202-
wasRestarted = true
203-
}
204-
},
205-
}),
206-
],
207-
},
208-
})
209-
210-
await devServer.startAndWatch(ts)
211-
cleanup(() => devServer.close())
212-
213-
await sleep(1000)
214-
215-
assert.deepEqual(receivedMessages.length, 4)
216-
}).timeout(10_000)
217-
218130
test('should restart server if receive hot-hook message', async ({ assert, fs }) => {
219131
await fs.createJson('tsconfig.json', { include: ['**/*'], exclude: [] })
220132
await fs.create(

0 commit comments

Comments
 (0)