Skip to content

Commit 5e0a927

Browse files
committed
fix: show errors when npm install fail
1 parent c13473b commit 5e0a927

File tree

1 file changed

+25
-14
lines changed

1 file changed

+25
-14
lines changed

commands/Invoke.ts

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -71,21 +71,25 @@ export default class Configure extends BaseCommand {
7171
* Install Encore
7272
*/
7373
const pkgFile = new files.PackageJsonFile(this.application.appRoot)
74-
pkgFile.install('@symfony/[email protected]');
75-
pkgFile.install('[email protected]');
76-
pkgFile.install('[email protected]');
77-
pkgFile.install('@babel/[email protected]');
78-
pkgFile.install('@babel/[email protected]');
79-
pkgFile.useClient(this.getPackageManager())
74+
pkgFile.install('@symfony/[email protected]')
75+
pkgFile.install('[email protected]')
76+
pkgFile.install('[email protected]')
77+
pkgFile.install('@babel/[email protected]')
78+
pkgFile.install('@babel/[email protected]')
79+
pkgFile.useClient(this.getPackageManager())
8080

8181
const spinner = logger.await(logger.colors.gray('configure @symfony/webpack-encore'))
8282

8383
try {
84-
await pkgFile.commitAsync()
85-
spinner.update('Configured')
86-
spinner.stop()
84+
const response = await pkgFile.commitAsync()
85+
if (response && response.status === 1) {
86+
spinner.stop()
87+
logger.fatal({ message: 'Unable to configure encore', stack: response.stderr.toString() })
88+
} else {
89+
spinner.stop()
90+
logger.success('Configured encore successfully')
91+
}
8792
} catch (error) {
88-
spinner.update('Unable to install the package')
8993
spinner.stop()
9094
logger.fatal(error)
9195
}
@@ -218,11 +222,18 @@ pkgFile.useClient(this.getPackageManager())
218222
const spinner = logger.await(logger.colors.gray('installing @japa/runner, @japa/preset-adonis'))
219223

220224
try {
221-
await pkgFile.commitAsync()
222-
spinner.update('Installed')
223-
spinner.stop()
225+
const response = await pkgFile.commitAsync()
226+
if (response && response.status === 1) {
227+
spinner.stop()
228+
logger.fatal({
229+
message: 'Unable to configure tests runner',
230+
stack: response.stderr.toString(),
231+
})
232+
} else {
233+
spinner.stop()
234+
logger.success('Configured tests runner successfully')
235+
}
224236
} catch (error) {
225-
spinner.update('Unable to install packages')
226237
spinner.stop()
227238
logger.fatal(error)
228239
}

0 commit comments

Comments
 (0)