fix: using fs.open in place of the sleep hack from the last commit

Author: thetutlage

commands/Invoke.ts

@@ -7,12 +7,12 @@
 * file that was distributed with this source code.
 */
 
+import { open } from 'fs-extra'
+import { join } from 'path'
 import { BaseCommand, args } from '@adonisjs/ace'
 
 import { Manifest } from '../src/Manifest'
-import { ADONIS_ACE_CWD } from '../config/env'
-
-const sleep = (timeout: number) => new Promise((resolve) => setTimeout(resolve, timeout))
+import { ADONIS_ACE_CWD, ADONIS_BUILD_DIR } from '../config/env'
 
 /**
  * Invoke post install instructions
@@ -27,6 +27,33 @@ export default class Invoke extends BaseCommand {
   @args.string({ description: 'Name of the package for which to invoke post install instructions' })
   public name: string
 
+  /**
+   * Attempts to access the rc file handling the race condition of
+   * it's being accessed by another process.
+   */
+  private async accessRcFile (counter = 0) {
+    const buildDir = ADONIS_BUILD_DIR()
+    const cwd = ADONIS_ACE_CWD()!
+
+    /**
+     * Return early when we are unaware of the build
+     * directory
+     */
+    if (!buildDir) {
+      return
+    }
+
+    try {
+      await open(join(cwd, buildDir, '.adonisrc.json'), 'r+')
+    } catch (error) {
+      if (error.code === 'EBUSY' && counter < 3) {
+        await this.accessRcFile(counter + 1)
+      } else {
+        throw error
+      }
+    }
+  }
+
   /**
    * Invoked automatically by ace
    */
@@ -47,18 +74,11 @@ export default class Invoke extends BaseCommand {
     const { executeInstructions } = await import('@adonisjs/sink')
     await executeInstructions(this.name, cwd, this.application)
 
-    /**
-     * When we execute the instructions that updates the `.adonisrc.json` file, we watcher
-     * copies it's contents to the `build` directory.
-     *
-     * Once the copy is in progress, running the ace instructions leads to reading an empty
-     * `.adonisrc.json` file.
-     *
-     * Now there is no simple way to know when the separate process watching and processing
-     * files will copy the `.adonisrc.json` file. So we add a small cool off period in
-     * between.
-     */
-    await sleep(400)
+    try {
+      await this.accessRcFile()
+    } catch (error) {
+    }
+
     await new Manifest(cwd, this.logger).generate()
   }
 }