refactor: remove installation step from production build

The installation step doesn't solve a real problem, since one should always
install production dependencies on the production server. So the build
now only creates the final build, leaving the installation aside.

Author: thetutlage

commands/Build.ts

@@ -20,7 +20,7 @@ export default class Build extends BaseCommand {
   /**
    * Allows watching for file changes
    */
-  @flags.boolean({ description: 'Watch for file changes and re-build the project', alias: 'w' })
+  @flags.boolean({ description: 'Watch filesystem and re-compile changes', alias: 'w' })
   public watch: boolean
 
   /**
@@ -30,11 +30,21 @@ export default class Build extends BaseCommand {
   public production: boolean
 
   /**
-   * Use yarn when building for production to install dependencies
+   * Select the client for deciding the lock file to copy to the
+   * build folder
    */
-  @flags.string({ description: 'Select between npm or yarn for installing dependencies' })
+  @flags.string({ description: 'Select the package manager to decide which lock file to copy to the build folder' })
   public client: string
 
+  /**
+   * Detect changes by polling files
+   */
+  @flags.boolean({
+    description: 'Detect file changes by polling files instead of listening to filesystem events',
+    alias: 'p',
+  })
+  public poll: boolean
+
   /**
    * Invoked automatically by ace
    */
@@ -51,7 +61,7 @@ export default class Build extends BaseCommand {
      */
     if (!cwd || !ADONIS_IS_TYPESCRIPT()) {
       this.logger.error(
-        'Cannot build non-typescript project. Make sure to run "node ace build" from the project root',
+        'Cannot build a non-typescript project. Make sure to run "node ace build" from the project root',
       )
       return
     }
@@ -76,7 +86,7 @@ export default class Build extends BaseCommand {
       if (this.production) {
         await new Compiler(cwd, false, [], this.logger).compileForProduction(this.client)
       } else if (this.watch) {
-        await new Watcher(cwd, false, [], this.logger).watch()
+        await new Watcher(cwd, false, [], this.logger).watch(this.poll)
       } else {
         await new Compiler(cwd, false, [], this.logger).compile()
       }

src/Compiler/index.ts

@@ -13,6 +13,7 @@ import copyfiles from 'cpy'
 import debounce from 'debounce'
 import tsStatic from 'typescript'
 import { join, relative } from 'path'
+import { Colors } from '@poppinss/colors'
 import { Logger } from '@poppinss/fancy-logs'
 import { remove, outputJSON } from 'fs-extra'
 import { resolveFrom } from '@poppinss/utils'
@@ -21,7 +22,6 @@ import { iocTransformer } from '@adonisjs/ioc-transformer'
 
 import { RcFile } from '../RcFile'
 import { Manifest } from '../Manifest'
-import { Installer } from '../Installer'
 import { HttpServer, DummyHttpServer } from '../HttpServer'
 import {
   RCFILE_NAME,
@@ -70,6 +70,8 @@ export class Compiler {
    */
   private getRelativeUnixPath = mem((absPath: string) => slash(relative(this.appRoot, absPath)))
 
+  private colors = new Colors()
+
   constructor (
     public appRoot: string,
     private serveApp: boolean,
@@ -244,22 +246,18 @@ export class Compiler {
     await this.copyMetaFiles(config.options.outDir!, pkgFiles)
     this.buildTypescriptSource(config)
     await this.copyAdonisRcFile(config.options.outDir!)
+    await this.manifest.generate()
 
-    this.logger.info({ message: 'installing production dependencies', suffix: client })
-    await new Installer(config.options.outDir!, client).install()
+    const installCommand = client === 'npm'
+      ? 'npm ci --production'
+      : 'yarn install --production'
 
-    /**
-     * Manifest can be generated without blocking the flow
-     */
-    this.manifest.generate()
+    console.log('   Run the following commands to start the server in production')
+    const relativeBuildPath = this.getRelativeUnixPath(config.options.outDir!)
 
-    /**
-     * Start HTTP server in production
-     */
-    if (this.serveApp) {
-      this.createHttpServer(config.options.outDir!)
-      this.httpServer.start()
-    }
+    console.log(`   ${this.colors.gray('$')} ${this.colors.cyan(`cd ${relativeBuildPath}`)}`)
+    console.log(`   ${this.colors.gray('$')} ${this.colors.cyan(installCommand)}`)
+    console.log(`   ${this.colors.gray('$')} ${this.colors.cyan('node server.js')}`)
 
     return true
   }

test/compiler.spec.ts

@@ -275,7 +275,7 @@ test.group('Compiler', (group) => {
     ])
   }).timeout(0)
 
-  test('build for production by doing npm install', async (assert) => {
+  test('build for production should copy package files to build folder', async (assert) => {
     const logger = new Logger({ fake: true })
 
     await fs.add('.adonisrc.json', JSON.stringify({
@@ -325,7 +325,6 @@ test.group('Compiler', (group) => {
       'underline(magenta(pending)) compiling typescript source files',
       'underline(green(success)) built successfully',
       'underline(blue(info)) copy .adonisrc.json dim(yellow(build))',
-      'underline(blue(info)) installing production dependencies dim(yellow(npm))',
     ])
 
     const hasPackageLock = await fs.fsExtra.pathExists(join(fs.basePath, 'build', 'package-lock.json'))