Skip to content

Commit 92eb2c6

Browse files
committed
test: use another port in dev server test
`get-port` maintains a list of ports that have already been returned by the getPort function. therefore the test that verifies that getPort returns 3333 was failing
1 parent 6304c94 commit 92eb2c6

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

tests/dev_server.spec.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ import { DevServer } from '../index.js'
1313
import { setTimeout as sleep } from 'node:timers/promises'
1414

1515
test.group('DevServer', () => {
16-
test('start() execute onDevServerStarted hook', async ({ assert, fs }) => {
16+
test('start() execute onDevServerStarted hook', async ({ assert, fs, cleanup }) => {
1717
assert.plan(1)
18+
1819
await fs.create('bin/server.js', `process.send({ isAdonisJS: true, environment: 'web' })`)
20+
await fs.create('.env', 'PORT=3334')
1921

2022
const devServer = new DevServer(fs.baseUrl, {
2123
assets: {
@@ -35,12 +37,15 @@ test.group('DevServer', () => {
3537
})
3638

3739
await devServer.start()
40+
cleanup(() => devServer.close())
3841
await sleep(600)
3942
})
4043

4144
test('startAndWatch() execute onDevServerStarted hook', async ({ assert, fs, cleanup }) => {
4245
assert.plan(1)
46+
4347
await fs.create('bin/server.js', `process.send({ isAdonisJS: true, environment: 'web' })`)
48+
await fs.create('.env', 'PORT=3334')
4449

4550
const devServer = new DevServer(fs.baseUrl, {
4651
assets: {
@@ -73,11 +78,10 @@ test.group('DevServer', () => {
7378
})
7479
await fs.create('index.ts', 'console.log("hey")')
7580
await fs.create('bin/server.js', `process.send({ isAdonisJS: true, environment: 'web' })`)
81+
await fs.create('.env', 'PORT=3334')
7682

7783
const devServer = new DevServer(fs.baseUrl, {
78-
assets: {
79-
enabled: false,
80-
},
84+
assets: { enabled: false },
8185
nodeArgs: [],
8286
scriptArgs: [],
8387
hooks: {
@@ -95,7 +99,7 @@ test.group('DevServer', () => {
9599
cleanup(() => devServer.close())
96100

97101
await sleep(100)
98-
await fs.create('index.ts', 'sdf')
102+
await fs.create('index.ts', 'foo')
99103
await sleep(10)
100104
})
101105
})

0 commit comments

Comments
 (0)