refactor: use newer syntax for test suites

Author: thetutlage

commands/Test.ts

@@ -7,7 +7,7 @@
  * file that was distributed with this source code.
  */
 
-import { BaseCommand, flags } from '@adonisjs/core/build/standalone'
+import { BaseCommand, flags, args } from '@adonisjs/core/build/standalone'
 import { JapaFlags } from '../src/Contracts'
 
 /**
@@ -20,6 +20,9 @@ export default class Test extends BaseCommand {
     stayAlive: true,
   }
 
+  @args.spread({ description: 'Run tests for only the specified suites', required: false })
+  public suites: string[]
+
   /**
    * Allows watching for file changes
    */
@@ -44,24 +47,27 @@ export default class Test extends BaseCommand {
   @flags.array({ description: 'CLI options to pass to the node command line' })
   public nodeArgs: string[] = []
 
-  @flags.array({ description: 'Run tests for only specified tags' })
+  /**
+   * Filter by tags
+   */
+  @flags.array({ description: 'Filter tests by tags' })
   public tags: string[]
 
-  @flags.array({ description: 'Run all the tests except the tests using specified tags' })
+  /**
+   * Filter by tags
+   */
+  @flags.array({ description: 'Filter tests by ignoring tags' })
   public ignoreTags: string[]
 
-  @flags.number({ description: 'Define timeout for tests' })
+  /**
+   * Customize tests timeout
+   */
+  @flags.number({ description: 'Customize tests timeout' })
   public timeout: number
 
-  @flags.array({ description: 'Run tests for only the specified suites' })
-  public suites: string[]
-
-  @flags.array({ description: 'Run tests for only the specified groups' })
-  public groups: string[]
-
-  @flags.array({ description: 'Run tests with the specified titles' })
-  public tests: string[]
-
+  /**
+   * Force exit the tests runner
+   */
   @flags.boolean({ description: 'Force exit the tests runner process' })
   public forceExit: boolean
 
@@ -78,20 +84,12 @@ export default class Test extends BaseCommand {
       filters['--timeout'] = this.timeout
     }
 
-    if (this.tests) {
-      filters['--tests'] = this.tests
-    }
-
-    if (this.groups) {
-      filters['--groups'] = this.groups
+    if (this.tags) {
+      filters['--tags'] = this.tags
     }
 
     if (this.suites) {
-      filters['--suites'] = this.suites
-    }
-
-    if (this.tags) {
-      filters['--tags'] = this.tags
+      filters._ = this.suites
     }
 
     if (this.ignoreTags) {

src/Contracts/index.ts

@@ -8,12 +8,10 @@
  */
 
 export type JapaFlags = Partial<{
-  '--tests': string[]
+  '_': string[]
   '--tags': string[]
-  '--groups': string[]
   '--ignore-tags': string[]
   '--files': string[]
   '--timeout': number
-  '--suites': string[]
   '--force-exit': boolean
 }>

src/Test/process.ts

@@ -26,29 +26,32 @@ export class TestProcess {
     private logger: typeof uiLogger,
     private env: { [key: string]: string } = {}
   ) {
-    this.nodeArgs = nodeArgs.reduce((result, arg) => {
+    this.nodeArgs = nodeArgs.reduce<string[]>((result, arg) => {
       result = result.concat(arg.split(' '))
       return result
-    }, [] as string[])
+    }, [])
   }
 
   /**
    * Start the HTTP server as a child process.
    */
   public async run() {
     this.logger.info('running tests...')
-    const filters = Object.keys(this.filters).reduce((result, filter) => {
+    const filters = Object.keys(this.filters).reduce<string[]>((result, filter) => {
       const value = this.filters[filter]
 
-      result.push(filter)
+      if (filter !== '_') {
+        result.push(filter)
+      }
+
       if (Array.isArray(value)) {
         result.push(...value)
       } else {
         result.push(value)
       }
 
       return result
-    }, [] as string[])
+    }, [])
 
     try {
       await execa.node(this.sourceFile, filters, {