Skip to content

Commit b6b8795

Browse files
committed
refactor!: move to stable assembler hooks APIs
1 parent 293e100 commit b6b8795

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

src/hooks.ts

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,22 @@ import {
1111
RcFile,
1212
AssemblerHookNode,
1313
AssemblerHookHandler,
14-
HttpServerMessageHookHandler,
1514
SourceFileChangedHookHandler,
1615
} from '@adonisjs/application/types'
1716
import { RuntimeException } from '@poppinss/utils'
1817
import Hooks from '@poppinss/hooks'
1918

2019
export class AssemblerHooks {
21-
#config: RcFile['unstable_assembler']
20+
#config: RcFile['hooks']
2221

2322
#hooks = new Hooks<{
2423
onBuildStarting: [Parameters<AssemblerHookHandler>, []]
2524
onBuildCompleted: [Parameters<AssemblerHookHandler>, []]
2625
onDevServerStarted: [Parameters<AssemblerHookHandler>, []]
2726
onSourceFileChanged: [Parameters<SourceFileChangedHookHandler>, []]
28-
onHttpServerMessage: [Parameters<HttpServerMessageHookHandler>, []]
2927
}>()
3028

31-
constructor(config: RcFile['unstable_assembler']) {
29+
constructor(config: RcFile['hooks']) {
3230
this.#config = config
3331
}
3432

@@ -56,9 +54,6 @@ export class AssemblerHooks {
5654
...(this.#config?.onSourceFileChanged || []).map(async (node) =>
5755
this.#hooks.add('onSourceFileChanged', await this.#resolveHookNode(node))
5856
),
59-
...(this.#config?.onHttpServerMessage || []).map(async (node) =>
60-
this.#hooks.add('onHttpServerMessage', await this.#resolveHookNode(node))
61-
),
6257
])
6358
}
6459

@@ -103,11 +98,4 @@ export class AssemblerHooks {
10398
async onBuildCompleted(...args: Parameters<AssemblerHookHandler>) {
10499
await this.#hooks.runner('onBuildCompleted').run(...args)
105100
}
106-
107-
/**
108-
* When a message is received from the HTTP server process
109-
*/
110-
async onHttpServerMessage(...args: Parameters<HttpServerMessageHookHandler>) {
111-
await this.#hooks.runner('onHttpServerMessage').run(...args)
112-
}
113101
}

src/types.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,7 @@ export type DevServerOptions = {
124124
/**
125125
* Hooks to execute at different stages
126126
*/
127-
hooks?: Pick<
128-
NonNullable<RcFile['unstable_assembler']>,
129-
'onDevServerStarted' | 'onSourceFileChanged' | 'onHttpServerMessage'
130-
>
127+
hooks?: Pick<NonNullable<RcFile['hooks']>, 'onDevServerStarted' | 'onSourceFileChanged'>
131128
}
132129

133130
/**
@@ -224,7 +221,7 @@ export type BundlerOptions = {
224221
/**
225222
* Hooks to execute at different stages
226223
*/
227-
hooks?: Pick<NonNullable<RcFile['unstable_assembler']>, 'onBuildCompleted' | 'onBuildStarting'>
224+
hooks?: Pick<NonNullable<RcFile['hooks']>, 'onBuildCompleted' | 'onBuildStarting'>
228225
}
229226

230227
/**

0 commit comments

Comments
 (0)