fix: wait for assembler hooks node to be resolved

Author: Julien-R44

src/hooks.ts

@@ -48,10 +48,10 @@ export class AssemblerHooks {
    */
   async registerDevServerHooks() {
     await Promise.all([
-      this.#config?.onDevServerStarted?.map(async (node) =>
+      ...(this.#config?.onDevServerStarted || []).map(async (node) =>
         this.#hooks.add('onDevServerStarted', await this.#resolveHookNode(node))
       ),
-      this.#config?.onSourceFileChanged?.map(async (node) =>
+      ...(this.#config?.onSourceFileChanged || []).map(async (node) =>
         this.#hooks.add('onSourceFileChanged', await this.#resolveHookNode(node))
       ),
     ])
@@ -62,10 +62,10 @@ export class AssemblerHooks {
    */
   async registerBuildHooks() {
     await Promise.all([
-      this.#config?.onBuildStarting?.map(async (node) =>
+      ...(this.#config?.onBuildStarting || []).map(async (node) =>
         this.#hooks.add('onBuildStarting', await this.#resolveHookNode(node))
       ),
-      this.#config?.onBuildCompleted?.map(async (node) =>
+      ...(this.#config?.onBuildCompleted || []).map(async (node) =>
         this.#hooks.add('onBuildCompleted', await this.#resolveHookNode(node))
       ),
     ])

tests/bundler.spec.ts

@@ -9,6 +9,8 @@
 
 import ts from 'typescript'
 import { test } from '@japa/runner'
+import { setTimeout as sleep } from 'node:timers/promises'
+
 import { Bundler } from '../index.js'
 
 test.group('Bundler', () => {
@@ -189,4 +191,33 @@ test.group('Bundler', () => {
 
     await bundler.bundle()
   })
+
+  test('wait for hooks to be registered', async ({ assert, fs }) => {
+    assert.plan(1)
+
+    await fs.createJson('tsconfig.json', {
+      include: ['**/*'],
+      exclude: [],
+    })
+    await fs.create('index.ts', 'console.log("hey")')
+    await fs.create('bin/server.js', `process.send({ isAdonisJS: true, environment: 'web' })`)
+    await fs.create('.env', 'PORT=3334')
+
+    const bundler = new Bundler(fs.baseUrl, ts, {
+      hooks: {
+        onBuildStarting: [
+          async () => {
+            await sleep(1000)
+            return {
+              default: () => {
+                assert.isTrue(true)
+              },
+            }
+          },
+        ],
+      },
+    })
+
+    await bundler.bundle()
+  })
 })

tests/dev_server.spec.ts

@@ -102,4 +102,39 @@ test.group('DevServer', () => {
     await fs.create('index.ts', 'foo')
     await sleep(10)
   })
+
+  test('wait for hooks to be registered', async ({ assert, fs, cleanup }) => {
+    assert.plan(1)
+
+    await fs.createJson('tsconfig.json', {
+      include: ['**/*'],
+      exclude: [],
+    })
+    await fs.create('index.ts', 'console.log("hey")')
+    await fs.create('bin/server.js', `process.send({ isAdonisJS: true, environment: 'web' })`)
+    await fs.create('.env', 'PORT=3334')
+
+    const devServer = new DevServer(fs.baseUrl, {
+      assets: { enabled: false },
+      nodeArgs: [],
+      scriptArgs: [],
+      hooks: {
+        onDevServerStarted: [
+          async () => {
+            await sleep(400)
+            return {
+              default: () => {
+                assert.isTrue(true)
+              },
+            }
+          },
+        ],
+      },
+    })
+
+    await devServer.startAndWatch(ts)
+    cleanup(() => devServer.close())
+
+    await sleep(500)
+  })
 })