Skip to content

Commit f0f9f6a

Browse files
committed
fix: install required packages by webpack encore
1 parent f9baac9 commit f0f9f6a

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

commands/Invoke.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,17 @@ export default class Configure extends BaseCommand {
7272
*/
7373
const pkgFile = new files.PackageJsonFile(this.application.appRoot)
7474
pkgFile.install('@symfony/webpack-encore')
75+
pkgFile.install('webpack')
76+
pkgFile.install('webpack-cli')
77+
pkgFile.install('@babel/core')
78+
pkgFile.install('@babel/preset-env')
7579
pkgFile.useClient(this.getPackageManager())
7680

77-
const spinner = logger.await(logger.colors.gray('installing @symfony/webpack-encore'))
81+
const spinner = logger.await(logger.colors.gray('configure @symfony/webpack-encore'))
7882

7983
try {
8084
await pkgFile.commitAsync()
81-
spinner.update('Installed')
85+
spinner.update('Configured')
8286
spinner.stop()
8387
} catch (error) {
8488
spinner.update('Unable to install the package')

test/configure-encore.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,15 @@ test.group('Configure Encore', (group) => {
4343
'utf-8'
4444
)
4545

46+
const pkgFile = await fs.get('package.json')
47+
assert.properties(JSON.parse(pkgFile).devDependencies, [
48+
'@babel/core',
49+
'@babel/preset-env',
50+
'@symfony/webpack-encore',
51+
'webpack',
52+
'webpack-cli',
53+
])
54+
4655
assert.isTrue(envFile)
4756
assert.equal(envExampleFile.trim(), '// app entrypoint')
4857
})

0 commit comments

Comments
 (0)