test: fix breaking tests

Author: thetutlage

commands/Invoke.ts

@@ -66,8 +66,10 @@ export default class Configure extends BaseCommand {
     try {
       await pkgFile.commitAsync()
       spinner.update('Installed')
+      spinner.stop()
     } catch (error) {
       spinner.update('Unable to install the package')
+      spinner.stop()
       logger.fatal(error)
     }
   }
@@ -103,16 +105,16 @@ export default class Configure extends BaseCommand {
     }
 
     /**
-     * Create "tests/functional/hello-world.spec.ts" file
+     * Create "tests/functional/hello_world.spec.ts" file
      */
     const helloWorldTestFile = new files.MustacheFile(
       this.application.appRoot,
-      'tests/functional/hello-world.spec.ts',
-      join(__dirname, '..', 'templates/tests/functional/hello-world.spec.txt')
+      'tests/functional/hello_world.spec.ts',
+      join(__dirname, '..', 'templates/tests/functional/hello_world.spec.txt')
     )
     if (!helloWorldTestFile.exists()) {
       helloWorldTestFile.apply({}).commit()
-      logger.action('create').succeeded('tests/functional/hello-world.spec.ts')
+      logger.action('create').succeeded('tests/functional/hello_world.spec.ts')
     }
 
     /**
@@ -157,8 +159,10 @@ export default class Configure extends BaseCommand {
     try {
       await pkgFile.commitAsync()
       spinner.update('Installed')
+      spinner.stop()
     } catch (error) {
       spinner.update('Unable to install packages')
+      spinner.stop()
       logger.fatal(error)
     }
   }

templates/tests/functional/hello-world.spec.txt renamed to templates/tests/functional/hello_world.spec.txt

@@ -35,7 +35,7 @@ test.group('Configure Encore', (group) => {
       const app = new Application(fs.basePath, 'test', {})
 
       const invoke = new Invoke(app, new Kernel(app).mockConsoleOutput())
-      invoke.name = 'encore'
+      invoke.packages = ['encore']
       await invoke.run()
 
       const envFile = await fs.fsExtra.pathExists(join(fs.basePath, 'webpack.config.js'))

test/configure-encore.spec.ts

@@ -0,0 +1,49 @@
+/*
+ * @adonisjs/assembler
+ *
+ * (c) Harminder Virk <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+import test from 'japa'
+import { join } from 'path'
+import { Kernel } from '@adonisjs/ace'
+import { Filesystem } from '@poppinss/dev-utils'
+import { Application } from '@adonisjs/application'
+
+import Invoke from '../commands/Invoke'
+
+const fs = new Filesystem(join(__dirname, '__app'))
+
+test.group('Configure Tests', (group) => {
+  group.afterEach(async () => {
+    await fs.cleanup()
+  })
+
+  test
+    .skipInCI('setup tests', async (assert) => {
+      await fs.add(
+        'package.json',
+        JSON.stringify({
+          name: 'sample_app',
+        })
+      )
+
+      await fs.ensureRoot()
+      const app = new Application(fs.basePath, 'test', {})
+
+      const invoke = new Invoke(app, new Kernel(app).mockConsoleOutput())
+      invoke.packages = ['tests']
+      await invoke.run()
+
+      assert.isTrue(await fs.fsExtra.pathExists(join(fs.basePath, 'test.ts')))
+      assert.isTrue(await fs.fsExtra.pathExists(join(fs.basePath, 'tests/bootstrap.ts')))
+      assert.isTrue(
+        await fs.fsExtra.pathExists(join(fs.basePath, 'tests/functional/hello_world.spec.ts'))
+      )
+      assert.isTrue(await fs.fsExtra.pathExists(join(fs.basePath, 'contracts/tests.ts')))
+    })
+    .timeout(0)
+})

test/configure-tests.spec.ts

@@ -38,7 +38,7 @@ test.group('Invoke', (group) => {
     const app = new Application(fs.basePath, 'test', {})
 
     const invoke = new Invoke(app, new Kernel(app).mockConsoleOutput())
-    invoke.name = '@adonisjs/sample'
+    invoke.packages = ['@adonisjs/sample']
     await invoke.run()
 
     const envFile = await fs.fsExtra.readFile(join(fs.basePath, '.env'), 'utf-8')