[v5] Can't retrieve FormData with request.all() with autoprocess false

[D-Marc1]

I'm using Adonis 5. I can't retrieve FormData (multipart/form-data) with request.all() if autoProcess is false for streaming uploads. You used to be able to get the body in v4 with request.multipart.field, but this doesn't exist in v5. Is this a bug in v5 or not yet implemented?

[D-Marc1]

@thetutlage Sorry, don't mean to bother you, but just trying to confirm if this is a bug or not, in case I should raise an issue for this.

[thetutlage]

You cannot get the body without processing the stream. This is what request.multipart.process does. Files + Fields are part of the same stream.

Also in v4, you were collecting body manually and now it is collected automatically, that is the only difference and rest is all the same.

In the following example you have the body

await request.multipart.process()
console.log(request.all())

[D-Marc1]

Could I request having an option to collect the body manually then? Otherwise, there's no way of retrieving the request data before processing the file, like you were able to in v4. It seems like v5 is adding convenience at the expense of removing functionality that existed in v4, as you can only retrieve the request text data after the file is processed.

For anyone who googles this, right now, my solution is to simply pass in the values as query string parameters, but it would be nice be able to achieve this with FormData being passed to the body.

[thetutlage]

I am not sure how you can collect the values before as there is no guarantee that the field will be emitted before the file. Again, it will be nice if you can share a concrete example

[thetutlage]

It seems like v5 is adding convenience at the expense of removing functionality that existed in v4, as you can only retrieve the request text data after the file is processed

This is simply an assumption you are making without understanding the internals. In v4 the following code works by co-incidence

request.multipart.field((name, value) => {
  body[name] = value;
});

request.multipart.file('name', () => {
  console.log(body)
});

You are assuming that the field callback will always be executed before the file callback and that is not 100% guaranteed. It depends upon how the multipart data is put together by the client.

[D-Marc1]

Appreciate the super fast replies! Thanks for letting me know. I actually didn't know this. I should probably check back on projects I've done in v4 then.

An example for why I would need this would be a situation where I'm inserting data into a database first or using text input values for the file names or folders. There's some cases where it's useful to wrap it in a transaction, so the inserted data would get rolled back if the file upload fails. Consider the following:

const requestData = request.all();

await Database.transaction(async (trx) => {
  const user = await User.create(requestData, { client: trx });
  
  const { id } = user.$attributes;

  request.multipart.onFile('file', {}, async (file) => {
    const params = {
      Bucket: 'my-bucket',
      Key: `users/${id}.jpg`,
      Body: file,
    };

    const s3 = new AWS.S3();

    await s3.upload(params).promise();
  });

  await request.multipart.process();
});