[V5] Listen to non-numeric port

[thespino]

Hi, i'm hosting an Adonis api server on IIS with iisnode.
Iisnode uses pipe ports, which are strings, to proxy connections. In order for this to work, I always have to edit this line:

core/src/Ignitor/HttpServer/index.ts

Line 161 in f8ce27f

const port = Number(this.application.env.get('PORT', '3333'))

in node_modules removing the cast to number.

Of course it's really bad approach, but I wonder if the cast is really needed. Can it be possible that this will be removed in future releases?

Thanks.

[thetutlage]

You don't have to if you validate the environment variable as a number, then AdonisJS will convert it to a number from a string representation of a number. https://docs.adonisjs.com/guides/environment-variables#envschemanumber

[thespino]

True, but what I mean is:
On windows there are named pipe ports (https://en.wikipedia.org/wiki/Named_pipe#In_Windows) which are special ports used by some programs to communicate between each other, like iisnode does. Those ports aren't numeric, they're strings like "\.\pipe\foo".

So, the Number cast in core/src/Ignitor/HttpServer/index.ts is not valid (returns NaN). That's why I have to edit node_modules each time.

I know it's strange and very specific, that's why I put this in ideas category. In normal situations the Number cast is the expected behaviour.

Thanks a lot, Have a nice day!