`npm run build` fails after upgrading packages to their latest versions #4061

leocabeza · 2023-02-05T20:00:46Z

leocabeza
Feb 5, 2023

After upgrading all dependencies and devDependencies, yarn build command is returning a Typescript error.

What have I tried?

Removing yarn-lock.json, removing node_modules folder, installing again with yarn install
Restarting the Typescript server
Going back to the old version of my dependencies also didn't help, which I consider shouldn't be happening.

The error I'm getting is this:

yarn build
yarn run v1.22.19
$ node ace build --production
[ info ]  detected { @symfony/webpack-encore }
[ info ]  building frontend assets. Use { --no-assets } to disable
[ encore ] Running webpack ...
[ encore ] Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[ encore ] Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[ encore ] Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[ encore ] Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[ encore ]  DONE  Compiled successfully in 5316ms2:47:26 PM

8 files written to public/assets
[ encore ] webpack compiled successfully
[ info ]  cleaning up "./build" directory
[ info ]  compiling typescript source files
[ error ]  typescript compiler errors
contracts/auth.ts:37:45 - error TS2344: Type 'typeof User' does not satisfy the constraint 'LucidProviderModel'.
  Type 'typeof User' is not assignable to type 'new () => LucidRow & { password?: string | null | undefined; rememberMeToken?: string | null | undefined; }'.
    Construct signature return types 'User' and 'LucidRow & { password?: string | null | undefined; rememberMeToken?: string | null | undefined; }' are incompatible.
      The types of 'fill' are incompatible between these types.
        Type '(value: Partial<{ email: string; id: number; name: string; createdAt: DateTime; updatedAt: DateTime; }>, allowExtraProperties?: boolean | undefined) => User' is not assignable to type '(value: Partial<{ password: string | null | undefined; rememberMeToken: string | null | undefined; }>, allowExtraProperties?: boolean | undefined) => LucidRow & { ...; }'.
          Types of parameters 'value' and 'value' are incompatible.
            Type 'Partial<{ password: string | null | undefined; rememberMeToken: string | null | undefined; }>' has no properties in common with type 'Partial<{ email: string; id: number; name: string; createdAt: DateTime; updatedAt: DateTime; }>'.

37       implementation: LucidProviderContract<typeof User>
                                               ~~~~~~~~~~~
contracts/auth.ts:38:35 - error TS2344: Type 'typeof User' does not satisfy the constraint 'LucidProviderModel'.

38       config: LucidProviderConfig<typeof User>
                                     ~~~~~~~~~~~


Cannot complete the build process as there are typescript errors. Use "--ignore-ts-errors" flag to ignore Typescript errors
[ info ]  cleaning up "./build" directory
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I leave a copy of some files in case it helps:

contracts/auth.ts:

/**
 * Contract source: https://git.io/JOdz5
 *
 * Feel free to let us know via PR, if you find something broken in this
 * file.
 */

import User from 'App/Models/User'

declare module '@ioc:Adonis/Addons/Auth' {
  /*
  |--------------------------------------------------------------------------
  | Providers
  |--------------------------------------------------------------------------
  |
  | The providers are used to fetch users. The Auth module comes pre-bundled
  | with two providers that are `Lucid` and `Database`. Both uses database
  | to fetch user details.
  |
  | You can also create and register your own custom providers.
  |
  */
  interface ProvidersList {
    /*
    |--------------------------------------------------------------------------
    | User Provider
    |--------------------------------------------------------------------------
    |
    | The following provider uses Lucid models as a driver for fetching user
    | details from the database for authentication.
    |
    | You can create multiple providers using the same underlying driver with
    | different Lucid models.
    |
    */
    user: {
      implementation: LucidProviderContract<typeof User>
      config: LucidProviderConfig<typeof User>
    }
  }

  /*
  |--------------------------------------------------------------------------
  | Guards
  |--------------------------------------------------------------------------
  |
  | The guards are used for authenticating users using different drivers.
  | The auth module comes with 3 different guards.
  |
  | - SessionGuardContract
  | - BasicAuthGuardContract
  | - OATGuardContract ( Opaque access token )
  |
  | Every guard needs a provider for looking up users from the database.
  |
  */
  interface GuardsList {
    /*
    |--------------------------------------------------------------------------
    | Web Guard
    |--------------------------------------------------------------------------
    |
    | The web guard uses sessions for maintaining user login state. It uses
    | the `user` provider for fetching user details.
    |
    */
    web: {
      implementation: SessionGuardContract<'user', 'web'>
      config: SessionGuardConfig<'user'>
    }
  }
}

new package.json:

{
  "name": "bbc-debora",
  "version": "1.0.0",
  "private": true,
  "scripts": {
    "dev": "run-s docker dev-watch",
    "docker": "docker compose up -d",
    "dev-watch": "node ace serve --watch",
    "dev-debug": "node ace serve --watch --node-args='--inspect'",
    "build": "node ace build --production",
    "start": "node server.js",
    "lint": "eslint . --ext=.ts",
    "format": "prettier --write ."
  },
  "devDependencies": {
    "@adonisjs/assembler": "^5.9.5",
    "@babel/core": "^7.20.12",
    "@babel/preset-env": "^7.20.2",
    "@symfony/webpack-encore": "^4.2.0",
    "adonis-preset-ts": "^2.1.0",
    "bulma": "^0.9.4",
    "eslint": "^8.33.0",
    "eslint-config-prettier": "^8.6.0",
    "eslint-plugin-adonis": "^2.1.1",
    "eslint-plugin-prettier": "^4.2.1",
    "file-loader": "^6.2.0",
    "npm-run-all": "^4.1.5",
    "pino-pretty": "^9.1.1",
    "prettier": "^2.8.3",
    "sass": "^1.58.0",
    "sass-loader": "^13.2.0",
    "typescript": "^4.9.5",
    "webpack": "^5.75.0",
    "webpack-cli": "^5.0.1",
    "youch": "^3.2.2",
    "youch-terminal": "^2.1.5"
  },
  "dependencies": {
    "@adonisjs/ally": "^4.1.5",
    "@adonisjs/auth": "^8.2.3",
    "@adonisjs/core": "^5.9.0",
    "@adonisjs/i18n": "^1.5.6",
    "@adonisjs/lucid": "^18.3.0",
    "@adonisjs/mail": "^8.1.2",
    "@adonisjs/repl": "^3.1.11",
    "@adonisjs/session": "^6.4.0",
    "@adonisjs/shield": "^7.1.0",
    "@adonisjs/view": "^6.2.0",
    "adonis-lucid-soft-deletes": "^1.4.3",
    "adonis5-sentry": "^3.1.0",
    "bulma-calendar": "^6.1.18",
    "diacritic": "^0.0.2",
    "luxon": "^3.2.1",
    "pdfkit": "^0.13.0",
    "pg": "^8.9.0",
    "pino-sentry": "^0.14.0",
    "proxy-addr": "^2.0.7",
    "reflect-metadata": "^0.1.13",
    "source-map-support": "^0.5.21"
  }
}

tsconfig.json:

{
  "extends": "./node_modules/adonis-preset-ts/tsconfig",
  "include": [
    "**/*"
  ],
  "exclude": [
    "node_modules",
    "build"
  ],
  "compilerOptions": {
    "outDir": "build",
    "rootDir": "./",
    "sourceMap": true,
    "paths": {
      "App/*": [
        "./app/*"
      ],
      "Config/*": [
        "./config/*"
      ],
      "Contracts/*": [
        "./contracts/*"
      ],
      "Database/*": [
        "./database/*"
      ]
    },
    "types": [
      "@adonisjs/core",
      "@adonisjs/repl",
      "@adonisjs/session",
      "@adonisjs/view",
      "@adonisjs/shield",
      "@adonisjs/lucid",
      "@adonisjs/auth",
      "@adonisjs/ally",
      "@adonisjs/i18n",
      "adonis5-sentry",
      "adonis-lucid-soft-deletes",
      "@adonisjs/mail"
    ]
  }
}

old package.json:

{
  "name": "bbc-debora",
  "version": "1.0.0",
  "private": true,
  "scripts": {
    "dev": "run-s docker dev-watch",
    "docker": "docker compose up -d",
    "dev-watch": "node ace serve --watch",
    "dev-debug": "node ace serve --watch --node-args='--inspect'",
    "build": "node ace build --production",
    "start": "node server.js",
    "lint": "eslint . --ext=.ts",
    "format": "prettier --write ."
  },
  "devDependencies": {
    "@adonisjs/assembler": "^5.8.1",
    "@symfony/webpack-encore": "^3.0.0",
    "adonis-preset-ts": "^2.1.0",
    "bulma": "^0.9.4",
    "eslint": "^8.20.0",
    "eslint-config-prettier": "^8.5.0",
    "eslint-plugin-adonis": "^2.1.0",
    "eslint-plugin-prettier": "^4.2.1",
    "file-loader": "^6.2.0",
    "npm-run-all": "^4.1.5",
    "pino-pretty": "^8.1.0",
    "prettier": "^2.7.1",
    "sass": "^1.54.0",
    "sass-loader": "^13.0.2",
    "typescript": "^4.7.4",
    "youch": "^3.2.0",
    "youch-terminal": "^2.1.4"
  },
  "dependencies": {
    "@adonisjs/ally": "^4.1.4",
    "@adonisjs/auth": "^8.2.1",
    "@adonisjs/core": "^5.8.5",
    "@adonisjs/i18n": "^1.5.6",
    "@adonisjs/lucid": "^18.1.0",
    "@adonisjs/mail": "^8.1.2",
    "@adonisjs/repl": "^3.1.11",
    "@adonisjs/session": "^6.4.0",
    "@adonisjs/shield": "^7.0.11",
    "@adonisjs/view": "^6.1.6",
    "adonis-lucid-soft-deletes": "^1.4.3",
    "adonis5-sentry": "^3.1.0",
    "bulma-calendar": "^6.1.18",
    "diacritic": "^0.0.2",
    "luxon": "^3.0.1",
    "pdfkit": "^0.13.0",
    "pg": "^8.7.3",
    "pino-sentry": "^0.13.0",
    "proxy-addr": "^2.0.7",
    "reflect-metadata": "^0.1.13",
    "source-map-support": "^0.5.21"
  }
}

leocabeza · 2023-02-05T20:39:12Z

leocabeza
Feb 5, 2023
Author

My temporary solution, was to change auth.ts line 34-37 from this:

    user: {
      implementation: LucidProviderContract<typeof User>
      config: LucidProviderConfig<typeof User>
    }

to this:

    user: {
      implementation: LucidProviderContract<any>
      config: LucidProviderConfig<any>
    }

0 replies

RomainLanz · 2023-02-06T15:13:37Z

RomainLanz
Feb 6, 2023
Maintainer

Hey @leocabeza! 👋🏻

Could you please dump your User model here?
It seems that you are missing some mandatory columns, like password.

0 replies

leocabeza · 2023-02-06T19:34:47Z

leocabeza
Feb 6, 2023
Author

@RomainLanz , sure, here it is (This file had no change between updates):

import { DateTime } from 'luxon'
import { BaseModel, column, HasOne, hasOne } from '@ioc:Adonis/Lucid/Orm'

import Setting from './Setting'

export default class User extends BaseModel {
  @column({ isPrimary: true })
  public id: number

  @column()
  public email: string

  @column()
  public name: string

  @column.dateTime({ autoCreate: true })
  public createdAt: DateTime

  @column.dateTime({ autoUpdate: true })
  public updatedAt: DateTime

  @hasOne(() => Setting)
  public setting: HasOne<typeof Setting>
}

3 replies

leocabeza Feb 6, 2023
Author

Also, I use google authentication for my app

RomainLanz Feb 6, 2023
Maintainer

As said, you are missing the password column, which is needed for the LucidProviderContract.

leocabeza Feb 6, 2023
Author

Got it, that worked! Do you know how come that wasn't a problem before? 🤔

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AdonisJS Framework

`npm run build` fails after upgrading packages to their latest versions #4061

Uh oh!

{{title}}

Uh oh!

Replies: 3 comments 3 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

AdonisJS Framework

npm run build fails after upgrading packages to their latest versions #4061

Uh oh!

leocabeza Feb 5, 2023

Replies: 3 comments · 3 replies

Uh oh!

Uh oh!

leocabeza Feb 5, 2023 Author

Uh oh!

RomainLanz Feb 6, 2023 Maintainer

Uh oh!

leocabeza Feb 6, 2023 Author

Uh oh!

leocabeza Feb 6, 2023 Author

Uh oh!

RomainLanz Feb 6, 2023 Maintainer

Uh oh!

leocabeza Feb 6, 2023 Author

`npm run build` fails after upgrading packages to their latest versions #4061

leocabeza
Feb 5, 2023

Replies: 3 comments 3 replies

leocabeza
Feb 5, 2023
Author

RomainLanz
Feb 6, 2023
Maintainer

leocabeza
Feb 6, 2023
Author

leocabeza Feb 6, 2023
Author

RomainLanz Feb 6, 2023
Maintainer

leocabeza Feb 6, 2023
Author