Service provider does not call the method from service

[melokki]

I am trying to create a new service provider for an external service I want to use, but when I call a method of the service I am getting the following error

TypeError: Oblio_1.default.generateInvoice is not a function

I've done this before and everything worked just fine, but now, it just won't work.

so, I've created a services folder where I've created my service

// file: services/oblio/OblioService.ts
export class OblioService { 

public async generateInvoice() {}
}

I've created the service provider

// file: providers/OblioProvider.ts
export default class OblioProvider {
  constructor(protected app: ApplicationContract) {}

  public register() {
    // Register your own bindings
  }

  public async boot() {
    this.app.container.singleton('App/Invoicing/Oblio', async () => {
      
      const { OblioService } = require('./../services/oblio/OblioService')
      
      const client = axios.create({
        baseURL: 'https://test.test',
      })
      return new OblioService(client)
    })
  }

  public async ready() {
    // App is ready
  }

  public async shutdown() {
    // Cleanup, since app is going down
  }
}

in contracts folder I've created the module

// file: contracts/oblio.ts
declare module '@ioc:App/Invoicing/Oblio' {
  import { OblioService } from 'Services/oblio/OblioService'

  const OblioInvoice: OblioService
  export default OblioInvoice
}

in my controller I'm calling the service like this:

import OblioInvoice from '@ioc:App/Invoicing/Oblio'

await OblioInvoice.generateInvoice(invoice)

and here I am getting the error

TypeError: Oblio_1.default.generateInvoice is not a function
         at Object.handler (/code/start/routes.ts:177:24)
         at Object.PreCompiler.runRouteHandler [as fn] (/code/node_modules/@adonisjs/http-server/build/src/Server/PreCompiler/index.js:44:50)
         at Runnable.invoke (/code/node_modules/co-compose/build/src/Runnable.js:55:48)
         at RouteModelBindingMiddleware.handle (/code/node_modules/@adonisjs/route-model-binding/build/src/middleware/route_model_binding.js:33:20)
         at Injector.callAsync (/code/node_modules/@adonisjs/fold/build/src/Ioc/Injector.js:124:30)
         at processTicksAndRejections (node:internal/process/task_queues:95:5)

[McSneaky]

Hmm, shouldn't you move boot() content to register()? 🤔

[melokki]

same thing happens if I put it in register()

[RomainLanz]

Please explain why you are registering a service provider for an app-level service?
Why not directly import it inside your code?

class OblioService {
  public async generateInvoice(invoice) {}
}


const client = axios.create({
  baseURL: 'https://test.test',
})
const oblioService = new OblioService(client)
export default oblioService

import OblioInvoice from 'App/Invoicing/Oblio'

await OblioInvoice.generateInvoice(invoice)

[melokki]

Well, I thought I can take advantage of the IoC container to have a single instance of the provider available in application , that way I won't need to create a new instance of the service every time I need to use it

[RomainLanz]

You don't need that to create a singleton. The example above make OblioService a singleton without needing to use the IoC Container.

More info on it: https://adocasts.com/lessons/lets-learn-adonis-5-static-non-static-and-singleton-services

[melokki]

Yup, it worked like a charm, didn't know I can do this

Thank you very much :)