Join Aliases And Serlialised Models

[the-mediocre-dev]

Description

Lucid does not alias joins by default, which can lead to strange / erroneous serialization when joining through a model.

I have created a repo to highlight the issue. Check the test.

Issue.query().join('comments', 'comments.issue_id', '=', 'issues.id')

The join here produces the following SQL

select * from "issues" inner join "comments" on "comments"."issue_id" = "issues"."id" 

the results of which, as there is no aliasing or explicit selecting, will have multiple id columns.

While the SQL is sane, the issue arises when the result set is serialised into the Issue model. As there are two comments, we end up with two issues, each having the id of one of the comments.

    Issue 1
    '$attributes': { id: 30, createdAt: [DateTime], updatedAt: [DateTime] },
    '$extras': { issue_id: '27', content: 'comment 1' },
    
    Issue 2
    '$attributes': { id: 31, createdAt: [DateTime], updatedAt: [DateTime] },
    '$extras': { issue_id: '27', content: 'comment 2' },

Having a look at a dump of a sample test run, you can see it seems the issue is being serialized from the comment ids.

Is this a bug, or am I using Lucid wrong and this is the expected behaviour?