Skip to content

Commit 160a671

Browse files
committed
chore: update dependencies
1 parent cbd92dd commit 160a671

File tree

9 files changed

+50
-23
lines changed

9 files changed

+50
-23
lines changed

benchmarks/adonisjs.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,20 @@ import { Application } from '@adonisjs/application'
1414

1515
import { defineConfig } from '../index.js'
1616
import { Server } from '../src/server/main.js'
17+
import { Logger } from '@adonisjs/logger'
1718

1819
const app = new Application(new URL('./', import.meta.url), { environment: 'web' })
1920
await app.init()
2021

2122
const encryption = new Encryption({ secret: 'averylongrandom32charslongsecret' })
2223

23-
const server = new Server(app, encryption, new Emitter(app), defineConfig({}))
24+
const server = new Server(
25+
app,
26+
encryption,
27+
new Emitter(app),
28+
new Logger({ enabled: false }),
29+
defineConfig({})
30+
)
2431
server.getRouter().get('/', async (ctx) => {
2532
return ctx.response.send({ hello: 'world' })
2633
})

package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,22 +39,22 @@
3939
"author": "virk,adonisjs",
4040
"license": "MIT",
4141
"devDependencies": {
42-
"@adonisjs/application": "^6.6.0-0",
42+
"@adonisjs/application": "^6.7.0-0",
4343
"@adonisjs/config": "^4.1.3-0",
4444
"@adonisjs/encryption": "^5.1.0-0",
45-
"@adonisjs/events": "^8.4.0-0",
45+
"@adonisjs/events": "^8.4.1-0",
4646
"@adonisjs/fold": "^9.9.0-0",
4747
"@adonisjs/logger": "^5.2.0-0",
48-
"@commitlint/cli": "^17.4.1",
49-
"@commitlint/config-conventional": "^17.4.0",
48+
"@commitlint/cli": "^17.4.2",
49+
"@commitlint/config-conventional": "^17.4.2",
5050
"@fastify/middie": "^8.1.0",
5151
"@japa/api-client": "^1.4.2",
5252
"@japa/assert": "^1.3.6",
5353
"@japa/expect-type": "^1.0.2",
5454
"@japa/run-failed-tests": "^1.1.0",
5555
"@japa/runner": "^2.2.2",
5656
"@japa/spec-reporter": "^1.3.2",
57-
"@swc/core": "^1.3.26",
57+
"@swc/core": "^1.3.27",
5858
"@types/accepts": "^1.3.5",
5959
"@types/content-disposition": "^0.5.5",
6060
"@types/cookie": "^0.5.1",
@@ -76,7 +76,7 @@
7676
"c8": "^7.12.0",
7777
"cross-env": "^7.0.3",
7878
"del-cli": "^5.0.0",
79-
"eslint": "^8.31.0",
79+
"eslint": "^8.32.0",
8080
"eslint-config-prettier": "^8.6.0",
8181
"eslint-plugin-adonis": "^3.0.3",
8282
"eslint-plugin-prettier": "^4.2.1",
@@ -87,7 +87,7 @@
8787
"husky": "^8.0.3",
8888
"np": "^7.6.3",
8989
"pem": "^1.14.6",
90-
"prettier": "^2.8.1",
90+
"prettier": "^2.8.3",
9191
"reflect-metadata": "^0.1.13",
9292
"supertest": "^6.3.3",
9393
"ts-node": "^10.9.1",
@@ -116,9 +116,9 @@
116116
"vary": "^1.1.2"
117117
},
118118
"peerDependencies": {
119-
"@adonisjs/application": "^6.6.0-0",
119+
"@adonisjs/application": "^6.7.0-0",
120120
"@adonisjs/encryption": "^5.1.0-0",
121-
"@adonisjs/events": "^8.4.0-0",
121+
"@adonisjs/events": "^8.4.1-0",
122122
"@adonisjs/fold": "^9.9.0-0"
123123
},
124124
"repository": {

src/router/brisk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export class BriskRoute extends Macroable {
3737
/**
3838
* Reference to the AdonisJS application
3939
*/
40-
#app: Application<any, any>
40+
#app: Application<any>
4141

4242
/**
4343
* Middleware registered on the router
@@ -50,7 +50,7 @@ export class BriskRoute extends Macroable {
5050
route: null | Route = null
5151

5252
constructor(
53-
app: Application<any, any>,
53+
app: Application<any>,
5454
routerMiddleware: ParsedGlobalMiddleware[],
5555
options: {
5656
pattern: string

src/router/main.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class Router extends LookupStore {
5252
/**
5353
* Application is needed to resolve string based controller expressions
5454
*/
55-
#app: Application<any, any>
55+
#app: Application<any>
5656

5757
/**
5858
* Store with tokenized routes
@@ -92,7 +92,7 @@ export class Router extends LookupStore {
9292
*/
9393
matchers = new Matchers()
9494

95-
constructor(app: Application<any, any>, encryption: Encryption, qsParser: Qs) {
95+
constructor(app: Application<any>, encryption: Encryption, qsParser: Qs) {
9696
super(encryption, qsParser)
9797
this.#app = app
9898
}

src/router/resource.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class RouteResource extends Macroable {
4545
/**
4646
* Reference to the AdonisJS application
4747
*/
48-
#app: Application<any, any>
48+
#app: Application<any>
4949

5050
/**
5151
* Middleware registered on the router
@@ -71,7 +71,7 @@ export class RouteResource extends Macroable {
7171
routes: Route[] = []
7272

7373
constructor(
74-
app: Application<any, any>,
74+
app: Application<any>,
7575
routerMiddleware: ParsedGlobalMiddleware[],
7676
options: {
7777
resource: string

src/router/route.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export class Route<Controller extends Constructor<any> = any> extends Macroable
7575
/**
7676
* Reference to the AdonisJS application
7777
*/
78-
#app: Application<any, any>
78+
#app: Application<any>
7979

8080
/**
8181
* Middleware registered on the router
@@ -107,7 +107,7 @@ export class Route<Controller extends Constructor<any> = any> extends Macroable
107107
#middleware: StoreRouteMiddleware[][] = []
108108

109109
constructor(
110-
app: Application<any, any>,
110+
app: Application<any>,
111111
routerMiddleware: ParsedGlobalMiddleware[],
112112
options: {
113113
pattern: string

src/server/main.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import onFinished from 'on-finished'
1111
import { Emitter } from '@adonisjs/events'
1212
import Middleware from '@poppinss/middleware'
13+
import type { Logger } from '@adonisjs/logger'
1314
import type { Encryption } from '@adonisjs/encryption'
1415
import type { Server as HttpsServer } from 'node:https'
1516
import type { Application } from '@adonisjs/application'
@@ -45,6 +46,13 @@ export class Server {
4546
},
4647
}
4748

49+
/**
50+
* Logger instance, a child logger is added
51+
* to the context to have request specific
52+
* logging capabilities.
53+
*/
54+
#logger: Logger
55+
4856
/**
4957
* Registered error handler (if any)
5058
*/
@@ -64,7 +72,7 @@ export class Server {
6472
/**
6573
* The application instance to be shared with the router
6674
*/
67-
#app: Application<any, any>
75+
#app: Application<any>
6876

6977
/**
7078
* The encryption instance to be shared with the router
@@ -109,14 +117,16 @@ export class Server {
109117
}
110118

111119
constructor(
112-
app: Application<any, any>,
120+
app: Application<any>,
113121
encryption: Encryption,
114122
emitter: Emitter<any>,
123+
logger: Logger,
115124
config: ServerConfig
116125
) {
117126
this.#app = app
118127
this.#emitter = emitter
119128
this.#config = config
129+
this.#logger = logger
120130
this.#encryption = encryption
121131
this.#qsParser = new Qs(this.#config.qs)
122132
this.#router = new Router(this.#app, this.#encryption, this.#qsParser)
@@ -265,7 +275,7 @@ export class Server {
265275
const ctx = new HttpContext(
266276
request,
267277
response,
268-
this.#app.logger.child({ request_id: request.id() }),
278+
this.#logger.child({ request_id: request.id() }),
269279
resolver
270280
)
271281

test_factories/router.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { Router } from '../src/router/main.js'
1616
import { QsParserFactory } from './qs_parser_factory.js'
1717

1818
type FactoryParameters = {
19-
app: Application<any, any>
19+
app: Application<any>
2020
encryption: Encryption
2121
}
2222

test_factories/server_factory.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* file that was distributed with this source code.
88
*/
99

10+
import { Logger } from '@adonisjs/logger'
1011
import { Emitter } from '@adonisjs/events'
1112
import type { Encryption } from '@adonisjs/encryption'
1213
import type { Application } from '@adonisjs/application'
@@ -18,7 +19,8 @@ import { defineConfig } from '../src/define_config.js'
1819
import type { ServerConfig } from '../src/types/server.js'
1920

2021
type FactoryParameters = {
21-
app: Application<any, any>
22+
app: Application<any>
23+
logger: Logger
2224
encryption: Encryption
2325
emitter: Emitter<any>
2426
config: Partial<ServerConfig>
@@ -38,6 +40,13 @@ export class ServerFactory {
3840
return this.#parameters.emitter || new Emitter(this.#getApp())
3941
}
4042

43+
/**
44+
* Returns the logger instance
45+
*/
46+
#getLogger() {
47+
return this.#parameters.logger || new Logger({ enabled: false })
48+
}
49+
4150
/**
4251
* Returns the config for the server class
4352
*/
@@ -76,6 +85,7 @@ export class ServerFactory {
7685
this.#getApp(),
7786
this.#createEncryption(),
7887
this.#getEmitter(),
88+
this.#getLogger(),
7989
this.#getConfig()
8090
)
8191
}

0 commit comments

Comments
 (0)