chore: improve test coverage

Author: thetutlage

factories/request.ts

@@ -41,7 +41,7 @@ export class RequestFactory {
       allowMethodSpoofing: false,
       trustProxy: proxyAddr.compile('loopback'),
       subdomainOffset: 2,
-      generateRequestId: true,
+      generateRequestId: false,
       ...this.#parameters.config,
     }
   }

package.json

@@ -184,7 +184,7 @@
     ],
     "exclude": [
       "tests/**",
-      "test_factories/**",
+      "factories/**",
       ".yalc/**"
     ]
   }

tests/exceptions/exception_handler.spec.ts

@@ -384,4 +384,26 @@ test.group('Exception handler | report', () => {
 
     assert.lengthOf(parsedLogs, 0)
   })
+
+  test('log request id in logs when request id exists', async ({ assert }) => {
+    const logs: string[] = []
+    const logger = new LoggerFactory().pushLogsTo(logs).merge({ enabled: true }).create()
+    const exceptionHandler = new HttpExceptionHandler(logger)
+    const ctx = new HttpContextFactory().create()
+
+    ctx.request.request.headers['x-request-id'] = '123'
+
+    const error = new Exception('Something went wrong', { status: 302 })
+    await exceptionHandler.report(error, ctx)
+
+    const parsedLogs = logs.map((line) => {
+      const logLine = JSON.parse(line)
+      return { message: logLine.msg, level: logLine.level, requestId: logLine['x-request-id'] }
+    })
+
+    assert.lengthOf(parsedLogs, 1)
+    assert.equal(parsedLogs[0].message, 'Something went wrong')
+    assert.equal(parsedLogs[0].requestId, '123')
+    assert.equal(parsedLogs[0].level, 30)
+  })
 })

tests/request.spec.ts

@@ -688,7 +688,10 @@ test.group('Request', () => {
 
   test('set x-request-id header when id method is called', async ({ assert }) => {
     const server = createServer((req, res) => {
-      const request = new RequestFactory().merge({ req, res, encryption }).create()
+      const request = new RequestFactory()
+        .merge({ req, res, encryption, config: { generateRequestId: true } })
+        .create()
+
       res.writeHead(200, { 'content-type': 'application/json' })
       res.end(
         JSON.stringify({