refactor: remove server.close method and export middleware NextFn

Author: thetutlage

src/server/main.ts

@@ -227,27 +227,6 @@ export class Server<NamedMiddleware extends Record<string, LazyImport<Middleware
     this.#underlyingHttpServer = server
   }
 
-  /**
-   * Close the underlying HTTP server
-   */
-  close() {
-    return new Promise<void>((resolve, reject) => {
-      if (!this.#underlyingHttpServer || !this.#underlyingHttpServer.listening) {
-        resolve()
-        return
-      }
-
-      this.#underlyingHttpServer.close((error) => {
-        /* c8 ignore next 3 */
-        if (error) {
-          return reject(error)
-        }
-
-        resolve()
-      })
-    })
-  }
-
   /**
    * Returns reference to the underlying HTTP server
    * in use

src/types/base.ts

@@ -7,6 +7,8 @@
  * file that was distributed with this source code.
  */
 
+export type { NextFn } from '@poppinss/middleware/types'
+
 /**
  * Class constructor type
  */

src/types/middleware.ts

@@ -8,9 +8,8 @@
  */
 
 import type { ContainerResolver } from '@adonisjs/fold'
-import type { NextFn } from '@poppinss/middleware/types'
 
-import type { Constructor } from './base.js'
+import type { Constructor, NextFn } from './base.js'
 import type { HttpContext } from '../http_context/main.js'
 
 /**

src/types/server.ts

@@ -7,11 +7,11 @@
  * file that was distributed with this source code.
  */
 
+import type { QSParserConfig } from './qs.js'
 import type { Constructor } from './base.js'
 import type { RequestConfig } from './request.js'
 import type { ResponseConfig } from './response.js'
 import type { HttpContext } from '../http_context/main.js'
-import { QSParserConfig } from './qs.js'
 
 /**
  * Error handler to handle HTTP errors

tests/server.spec.ts

@@ -47,36 +47,6 @@ test.group('Server', () => {
 
     assert.strictEqual(server.getNodeServer(), httpServer)
   })
-
-  test('close node server ', async ({ assert }) => {
-    assert.plan(1)
-
-    const app = new AppFactory().create()
-    const server = new ServerFactory().merge({ app }).create()
-    server.use([], [], {})
-
-    const httpServer = createServer(() => {}).listen(3000)
-    server.setNodeServer(httpServer)
-
-    httpServer.on('close', () => {
-      assert.isFalse(httpServer.listening)
-    })
-
-    await server.close()
-  })
-
-  test('noop when http server is not listening or not set', async ({ assert }) => {
-    const app = new AppFactory().create()
-    const server = new ServerFactory().merge({ app }).create()
-    server.use([], [], {})
-
-    assert.doesNotRejects(() => server.close())
-
-    const httpServer = createServer(() => {})
-    server.setNodeServer(httpServer)
-
-    assert.doesNotRejects(() => server.close())
-  })
 })
 
 test.group('Server | Response handling', () => {