Skip to content

Commit de6e719

Browse files
Drop support for node < 18, Ember < 4.4 (#757)
* Update pnpm * Drop support for node < 18 * Update package.json * Update .eslintrc.js * Add @ember/string * pnpm update * Try to fix embroider * Add ember-inflector * Update ember-try.js * Remove {{action}} * Update index.hbs * ember-prism -> ember-shiki * Replace ember-code-snippet with manual script * Update package.json * Update write-snippets.mjs * Update package.json * Ignore tests/dummy/app/snippets.js * Add 5.8 and 5.12 * Update README.md * Remove 3.28 from ember-try * Downgrade ember-inflector * Update ember-try.js
1 parent 8eb46e8 commit de6e719

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+11787
-8926
lines changed

.ember-cli

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
11
{
2-
/**
3-
Ember CLI sends analytics information by default. The data is completely
4-
anonymous, but there are times when you might want to disable this behavior.
5-
6-
Setting `disableAnalytics` to true will prevent any data from being sent.
7-
*/
8-
"disableAnalytics": false,
9-
102
/**
113
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
124
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.

.eslintignore

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,16 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/blueprints/**/*files/
4-
/vendor/
53

64
# compiled output
5+
/declarations/
76
/dist/
8-
/tmp/
9-
10-
# dependencies
11-
/node_modules/
127

138
# misc
149
/coverage/
1510
!.*
1611
.*/
17-
.eslintcache
1812

1913
# ember-try
2014
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/npm-shrinkwrap.json.ember-try
23-
/package.json.ember-try
24-
/package-lock.json.ember-try
25-
/yarn.lock.ember-try
15+
16+
tests/dummy/app/snippets.js

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ module.exports = {
2525
rules: {
2626
'ember/no-classic-classes': 'off',
2727
'ember/no-new-mixins': 'off',
28+
'ember/no-runloop': 'off',
2829
'ember/use-ember-data-rfc-395-imports': 'off',
2930
},
3031
overrides: [

.github/workflows/ci.yml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ jobs:
1919

2020
steps:
2121
- uses: actions/checkout@v4
22-
- uses: pnpm/action-setup@v3
22+
- uses: pnpm/action-setup@v4
2323
with:
24-
version: 7
24+
version: 10
2525
- name: Install Node
2626
uses: actions/setup-node@v4
2727
with:
28-
node-version: 14.x
28+
node-version: 18
2929
cache: pnpm
3030
- name: Install Dependencies
3131
run: pnpm install --frozen-lockfile
@@ -41,12 +41,12 @@ jobs:
4141

4242
steps:
4343
- uses: actions/checkout@v4
44-
- uses: pnpm/action-setup@v3
44+
- uses: pnpm/action-setup@v4
4545
with:
46-
version: 7
46+
version: 10
4747
- uses: actions/setup-node@v4
4848
with:
49-
node-version: 14.x
49+
node-version: 18
5050
cache: pnpm
5151
- name: Install Dependencies
5252
run: pnpm install --no-lockfile
@@ -63,10 +63,12 @@ jobs:
6363
fail-fast: false
6464
matrix:
6565
try-scenario:
66-
- ember-lts-3.28
67-
- ember-4.0
6866
- ember-lts-4.4
6967
- ember-lts-4.8
68+
- ember-lts-4.12
69+
- ember-lts-5.4
70+
- ember-lts-5.8
71+
- ember-lts-5.12
7072
- ember-release
7173
- ember-beta
7274
- ember-canary
@@ -75,13 +77,13 @@ jobs:
7577

7678
steps:
7779
- uses: actions/checkout@v4
78-
- uses: pnpm/action-setup@v3
80+
- uses: pnpm/action-setup@v4
7981
with:
80-
version: 7
82+
version: 10
8183
- name: Install Node
8284
uses: actions/setup-node@v4
8385
with:
84-
node-version: 14.x
86+
node-version: 18
8587
cache: pnpm
8688
- name: Install Dependencies
8789
run: pnpm install --frozen-lockfile

.gitignore

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,27 @@
1-
# See https://help.github.com/ignore-files/ for more about ignoring files.
2-
31
# compiled output
42
/dist/
5-
/tmp/
3+
/declarations/
64

75
# dependencies
8-
/bower_components/
96
/node_modules/
107

118
# misc
12-
/.sass-cache
9+
/.env*
10+
/.pnp*
1311
/.eslintcache
14-
/connect.lock
1512
/coverage/
16-
/libpeerconnection.log
1713
/npm-debug.log*
1814
/testem.log
1915
/yarn-error.log
2016

2117
# ember-try
2218
/.node_modules.ember-try/
23-
/bower.json.ember-try
2419
/npm-shrinkwrap.json.ember-try
2520
/package.json.ember-try
2621
/package-lock.json.ember-try
2722
/yarn.lock.ember-try
2823

2924
# broccoli-debug
3025
/DEBUG/
26+
27+
tests/dummy/app/snippets.js

.npmignore

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
/dist/
33
/tmp/
44

5-
# dependencies
6-
/bower_components/
7-
85
# misc
9-
/.bowerrc
106
/.editorconfig
117
/.ember-cli
128
/.env*
@@ -23,18 +19,18 @@
2319
/.template-lintrc.js
2420
/.travis.yml
2521
/.watchmanconfig
26-
/bower.json
2722
/CONTRIBUTING.md
2823
/ember-cli-build.js
2924
/testem.js
3025
/tests/
26+
/tsconfig.declarations.json
27+
/tsconfig.json
3128
/yarn-error.log
3229
/yarn.lock
3330
.gitkeep
3431

3532
# ember-try
3633
/.node_modules.ember-try/
37-
/bower.json.ember-try
3834
/npm-shrinkwrap.json.ember-try
3935
/package.json.ember-try
4036
/package-lock.json.ember-try

.npmrc

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,27 @@
1+
####################
2+
# super strict mode
3+
####################
14
auto-install-peers=false
5+
strict-peer-dependents=true
6+
resolve-peers-from-workspace-root=false
7+
8+
################
9+
# Optimizations
10+
################
11+
# Less strict, but required for tooling to not barf on duplicate peer trees.
12+
# (many libraries declare the same peers, which resolve to the same
13+
# versions)
14+
peers-suffix-max-length=40
15+
dedupe-injected-deps=true
16+
dedupe-peer-dependents=true
17+
public-hoist-pattern[]=ember-source
18+
sync-injected-deps-after-scripts[]=build
19+
sync-injected-deps-after-scripts[]=sync
20+
inject-workspace-packages=true
21+
22+
################
23+
# Compatibility
24+
################
25+
# highest is what everyone is used to, but
26+
# not ensuring folks are actually compatible with declared ranges.
27+
resolution-mode=highest

.prettierignore

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,15 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/vendor/
43

54
# compiled output
65
/dist/
7-
/tmp/
8-
9-
# dependencies
10-
/bower_components/
11-
/node_modules/
126

137
# misc
148
/coverage/
159
!.*
16-
.eslintcache
17-
.lint-todo/
10+
.*/
1811

1912
# ember-try
2013
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/npm-shrinkwrap.json.ember-try
23-
/package.json.ember-try
24-
/package-lock.json.ember-try
25-
/yarn.lock.ember-try
14+
15+
tests/dummy/app/snippets.js

.tool-versions

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
pnpm 10.7.1

.watchmanconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"ignore_dirs": ["tmp", "dist"]
2+
"ignore_dirs": ["dist"]
33
}

0 commit comments

Comments
 (0)