-
-
Notifications
You must be signed in to change notification settings - Fork 116
Open
Description
#917 moved some dependencies to peerDependencies but I'm not sure if that was actually needed, or what the benefits are of doing that.
Other addons can also use ember-file-upload and they are forced to also list these as peerDep if they don't use the dependency themselves, which is strange.
Looking at the current peerDep list; tracked-built-ins and ember-modifier should be moved to dependencies, in my opinion.
I'm not sure about the @glimmer/component package, but I believe that one is a virtual package in an Ember app and only needed for the types (so a devDep is probably fine)?
These changes would not be breaking AFAIK, if the version ranges are kept the same.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels