Skip to content

Re-evaluate the peerDeps #1139

@Windvis

Description

@Windvis

#917 moved some dependencies to peerDependencies but I'm not sure if that was actually needed, or what the benefits are of doing that.

Other addons can also use ember-file-upload and they are forced to also list these as peerDep if they don't use the dependency themselves, which is strange.

Looking at the current peerDep list; tracked-built-ins and ember-modifier should be moved to dependencies, in my opinion.

I'm not sure about the @glimmer/component package, but I believe that one is a virtual package in an Ember app and only needed for the types (so a devDep is probably fine)?

These changes would not be breaking AFAIK, if the version ranges are kept the same.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions