Skip to content

Commit cb3da3a

Browse files
authored
Merge pull request #203 from gzurbach/master
Fix importing `inject` from `@ember/service` deprecation warning
2 parents 3d21717 + fa7e8b3 commit cb3da3a

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# Changelog
22

33
## UNRELEASED
4+
- Fix importing `inject` from `@ember/service` deprecation warning
5+
46
### BREAKING CHANGES
57
- Messages can be programmatically closed by doing `message.close()`. Changing the `visible` property was broken.
68

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ The CSS animations are inspired by CSS from [alertify.js](http://fabien-d.github
2727

2828
```js
2929
import Component from '@glimmer/component';
30-
import { inject as service } from '@ember/service';
30+
import { service } from '@ember/service';
3131
import { action } from '@ember/object';
3232

3333
export default class MyComponent extends Component {

addon/components/ember-notify.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import { A } from '@ember/array';
22
import { computed } from '@ember/object';
33
import { oneWay } from '@ember/object/computed';
4-
import { inject as service } from '@ember/service';
4+
import * as emberService from '@ember/service';
55
import Component from '@ember/component';
66
import layout from '../templates/components/ember-notify';
77
import Message from 'ember-notify/message';
88

9+
// Preserve backward compatibility with Ember versions prior to 4.1
10+
const service = emberService.service ?? emberService.inject;
11+
912
export default Component.extend({
1013
layout,
1114

0 commit comments

Comments
 (0)