updated the code to handle null outpuT#894
Closed
Hajer-Dahmani wants to merge 2 commits intoadoptium:masterfrom
Closed
updated the code to handle null outpuT#894Hajer-Dahmani wants to merge 2 commits intoadoptium:masterfrom
Hajer-Dahmani wants to merge 2 commits intoadoptium:masterfrom
Conversation
…f-by: Hajer Dahmani [email protected] Signed-off-by: Hajer Dahmani <[email protected]>
✅ Deploy Preview for eclipsefdn-adoptium-trss canceled.
|
Member
hendrikebbers
left a comment
hendrikebbers
left a comment
There was a problem hiding this comment.
I would like to create some constants instead of having duplicate code that could lead to problems in the future when only 1 of the code blocks will be updated, and others are missed.
| { | ||
| testName: 'Pre Test', | ||
| testOutput: '', | ||
| testResult: 'FAILED', |
Member
There was a problem hiding this comment.
The strings 'Pre Test' and 'FAILED' (+ 'Post Test' and 'PASSED') are used at several places in this file. With this new addition it would be great of we can create constants for that strings.
…Fixes adoptium#894, signed-off-by: Hajer Dahmani [email protected] Signed-off-by: Hajer Dahmani <[email protected]>
Hajer-Dahmani
commented
Jul 22, 2024
Author
Hajer-Dahmani
left a comment
Hajer-Dahmani
left a comment
There was a problem hiding this comment.
I just implemented the changes you requested, thank you!
hendrikebbers
approved these changes
Jul 23, 2024
Member
|
@llxia I do not know how the check the error manualy in the netlify setup. Can you check if the behavior is correct now? |
Contributor
|
As discussed today, this PR should be updated. |
Contributor
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated the code to handle null output,
Fixes #879 ,
signed-off-by: Hajer Dahmani [email protected]