Skip to content

Commit 51b7317

Browse files
authored
Fix pingperf tests with liberty dockerfile update (#6684)
Fix pingperf tests with liberty dockerfile update Signed-off-by: LongyuZhang <[email protected]>
1 parent 94fe3dd commit 51b7317

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

external/criu/pingPerf.sh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,14 +106,15 @@ prepare() {
106106
curCommitID=$(git rev-parse HEAD)
107107
echo "Using dockerfile from OpenLiberty/ci.docker repo branch $openLibertyBranch with commit hash $curCommitID"
108108
if [[ $docker_os == "ubi" ]]; then
109-
# Temporarily OpenLiberty ubi dockerfile only supports openjdk 21, using it for 11 and 17 too
110-
libertyDockerfilePath="releases/latest/beta/Dockerfile.${docker_os}.openjdk21"
109+
# OpenLiberty doesn't provide ubi dockerfile for all jdk versions, use JDK17 dockerfile as the base file then replace jdk
110+
libertyDockerfilePath="releases/latest/full/Dockerfile.${docker_os}.openjdk17"
111111
# replace OpenLiberty dockerfile base image
112-
findCommandAndReplace "FROM icr.io\/appcafe\/ibm-semeru-runtimes:open-21-jre-${docker_os}9-minimal" "FROM local-ibm-semeru-runtimes:latest" $libertyDockerfilePath true '/'
113-
findCommandAndReplace "microdnf" "yum" $libertyDockerfilePath true
112+
findCommandAndReplace "FROM icr.io\/appcafe\/ibm-semeru-runtimes:open-17-jdk-${docker_os}" "FROM local-ibm-semeru-runtimes:latest" $libertyDockerfilePath true '/'
113+
findCommandAndReplace "microdnf" "yum" $libertyDockerfilePath false
114114
else # docker_os is ubuntu
115-
libertyDockerfilePath="releases/latest/beta/Dockerfile.${docker_os}.openjdk${jdkVersion}"
116-
findCommandAndReplace "FROM ibm-semeru-runtimes:open-${jdkVersion}-jre-jammy" "FROM local-ibm-semeru-runtimes:latest" $libertyDockerfilePath true '/'
115+
## OpenLiberty doesn't provide ubuntu dockerfile for all jdk versions, use JDK17 dockerfile as the base file then replace jdk
116+
libertyDockerfilePath="releases/latest/full/Dockerfile.${docker_os}.openjdk17"
117+
findCommandAndReplace "FROM ibm-semeru-runtimes:open-17-jre-jammy" "FROM local-ibm-semeru-runtimes:latest" $libertyDockerfilePath true '/'
117118
fi
118119
)
119120
}
@@ -148,7 +149,7 @@ buildImage() {
148149
echo "build image at $(pwd)..."
149150
sudo podman build -t local-ibm-semeru-runtimes:latest -f Dockerfile.open.releases.full . --build-arg DOCKER_REGISTRY_CREDENTIALS_USR=$DOCKER_REGISTRY_CREDENTIALS_USR --build-arg DOCKER_REGISTRY_CREDENTIALS_PSW=$DOCKER_REGISTRY_CREDENTIALS_PSW 2>&1 | tee build_semeru_image.log
150151
# Temporarily OpenLiberty ubi dockerfile only supports openjdk 17, not 11, need to add jdkVersion for ubuntu support later
151-
sudo podman build -t icr.io/appcafe/open-liberty:beta-instanton -f ci.docker/releases/latest/beta/Dockerfile.${docker_os}.openjdk21 ci.docker/releases/latest/beta
152+
sudo podman build -t icr.io/appcafe/open-liberty:beta-instanton -f ci.docker/releases/latest/full/Dockerfile.${docker_os}.openjdk17 ci.docker/releases/latest/beta
152153
sudo podman build -t ol-instanton-test-pingperf:latest -f Dockerfile.pingperf .
153154
}
154155

0 commit comments

Comments
 (0)