Skip to content

Commit fda05cb

Browse files
authored
Add Code Review Process Guideline (#6442)
Signed-off-by: Lan Xia <[email protected]>
1 parent 8984ffd commit fda05cb

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

Contributing.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,25 @@ You can skip `-f` in `git push` if you've never pushed your branch before.
112112
11. Convert PR to `Ready for review` once the PR is ready.
113113

114114

115+
## Code Review Process Guideline
116+
117+
To ensure high code quality, maintainability, and collaboration, all code changes should go through a structured review process before being merged into the main branch.
118+
119+
1. Assigning Reviewers
120+
- Assign at least one project committer as the reviewer.
121+
- Choose a reviewer with relevant knowledge of the codebase or feature.
122+
2. Reviewer Responsibilities
123+
- Review the code for:
124+
- Correctness and functionality
125+
- Code style and readability
126+
- Test coverage and reliability
127+
- Code maintainability and performance
128+
- Approve the PR once it meets quality standards.
129+
3. Merging the PR
130+
- Only the assigned reviewer should merge the PR after approval.
131+
- The author should not merge their own PR unless explicitly allowed under specific circumstances (e.g. hotfixes with prior approval).
132+
133+
115134
## Generative Artificial Intelligence (AI) Usage Guidelines
116135

117136
To ensure transparency, maintain the quality and integrity of our codebase, we have the following expectations regarding the use of generative AI tools in contributions:

0 commit comments

Comments
 (0)