java os.name property value ${buildjdk.os.name} not recognised on build-osuosl-aix72-ppc64-3

[smlambert]

Need to investigate

java os.name property value ${buildjdk.os.name} not recognised. Update the get-platform-prefix macrodef in stf.build/include/top.xml

---

From https://ci.adoptium.net/job/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/5/console running on build-osuosl-aix72-ppc64-3 :

02:52:00  BUILD FAILED
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/TKG/scripts/build_test.xml:95: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/common.xml:392: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/common.xml:383: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/STF/stf.build/include/top.xml:83: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/STF/stf.build/include/top.xml:517: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/STF/stf.build/include/top.xml:576: java os.name property value ${buildjdk.os.name} not recognised.  Update the get-platform-prefix macrodef in stf.build/include/top.xml
02:52:00  
02:52:00  Total time: 7 seconds
02:52:01  1
02:52:01  gmake[1]: *** [compile.mk:45: compile] Error 1
02:52:01  gmake[1]: Leaving directory '/home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/TKG'
02:52:01  gmake: *** [makefile:87: compile] Error 2
[Pipeline] }

[jiekang]

Related issue where it was intermittent and root cause was not found:

#3997

[jiekang]

The logs show one clean run:

02:51:58  setup-java-properties:
02:51:58       [echo] java_home is ${java_home}
02:51:58       [echo] java.home is /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image
02:51:58  [echoproperties] #Ant properties
02:51:58  [echoproperties] #Fri Aug 09 06:51:58 GMT 2024
02:51:58  [echoproperties] buildjdk./home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image/../lib=
02:51:58  [echoproperties] buildjdk./home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image/lib=
02:51:58  [echoproperties] buildjdk./lib=
02:51:58  [echoproperties] buildjdk./opt/freeware/lib=
02:51:58  [echoproperties] buildjdk./opt/freeware/lib/pthread=
02:51:58  [echoproperties] buildjdk./usr/jdk-17.0.11+9/../lib=
02:51:58  [echoproperties] buildjdk./usr/jdk-17.0.11+9/lib=
02:51:58  [echoproperties] buildjdk./usr/jdk-17.0.11+9/lib/server=
02:51:58  [echoproperties] buildjdk./usr/lib=
02:51:58  [echoproperties] buildjdk.OpenJDK=64-Bit Server VM Temurin-23+36-202408081905 (build 23-beta+36-ea, mixed mode)
02:51:58  [echoproperties] buildjdk.Property=settings\:
02:51:58  [echoproperties] buildjdk.file.encoding=UTF-8
02:51:58  [echoproperties] buildjdk.file.separator=/
02:51:58  [echoproperties] buildjdk.java.class.path=
02:51:58  [echoproperties] buildjdk.java.class.version=67.0
02:51:58  [echoproperties] buildjdk.java.home=/home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image
02:51:58  [echoproperties] buildjdk.java.io.tmpdir=/tmp/
02:51:58  [echoproperties] buildjdk.java.library.path=/home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image/lib/server
02:51:58  [echoproperties] buildjdk.java.runtime.name=OpenJDK Runtime Environment
02:51:58  [echoproperties] buildjdk.java.runtime.version=23-beta+36-ea
02:51:58  [echoproperties] buildjdk.java.specification.name=Java Platform API Specification
02:51:58  [echoproperties] buildjdk.java.specification.vendor=Oracle Corporation
02:51:58  [echoproperties] buildjdk.java.specification.version=23
02:51:58  [echoproperties] buildjdk.java.vendor=Eclipse Adoptium
02:51:58  [echoproperties] buildjdk.java.vendor.url=https\://adoptium.net/
02:51:58  [echoproperties] buildjdk.java.vendor.url.bug=https\://github.com/adoptium/adoptium-support/issues
02:51:58  [echoproperties] buildjdk.java.vendor.version=Temurin-23+36-202408081905
02:51:58  [echoproperties] buildjdk.java.version=23-beta
02:51:58  [echoproperties] buildjdk.java.version.date=2024-09-17
02:51:58  [echoproperties] buildjdk.java.vm.compressedOopsMode=Zero based
02:51:58  [echoproperties] buildjdk.java.vm.info=mixed mode
02:51:58  [echoproperties] buildjdk.java.vm.name=OpenJDK 64-Bit Server VM
02:51:58  [echoproperties] buildjdk.java.vm.specification.name=Java Virtual Machine Specification
02:51:58  [echoproperties] buildjdk.java.vm.specification.vendor=Oracle Corporation
02:51:58  [echoproperties] buildjdk.java.vm.specification.version=23
02:51:58  [echoproperties] buildjdk.java.vm.vendor=Eclipse Adoptium
02:51:58  [echoproperties] buildjdk.java.vm.version=23-beta+36-ea
02:51:58  [echoproperties] buildjdk.jdk.debug=release
02:51:58  [echoproperties] buildjdk.line.separator=\\n 
02:51:58  [echoproperties] buildjdk.native.encoding=ISO8859-1
02:51:58  [echoproperties] buildjdk.openjdk=version "23-beta" 2024-09-17
02:51:58  [echoproperties] buildjdk.os.arch=ppc64
02:51:58  [echoproperties] buildjdk.os.name=AIX
02:51:58  [echoproperties] buildjdk.os.version=7.2
02:51:58  [echoproperties] buildjdk.path.separator=\:
02:51:58  [echoproperties] buildjdk.stderr.encoding=ISO8859-1
02:51:58  [echoproperties] buildjdk.stdout.encoding=ISO8859-1
02:51:58  [echoproperties] buildjdk.sun.arch.data.model=64
02:51:58  [echoproperties] buildjdk.sun.boot.library.path=/home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image/lib
02:51:58  [echoproperties] buildjdk.sun.cpu.endian=big
02:51:58  [echoproperties] buildjdk.sun.io.unicode.encoding=UnicodeBig
02:51:58  [echoproperties] buildjdk.sun.java.launcher=SUN_STANDARD
02:51:58  [echoproperties] buildjdk.sun.jnu.encoding=ISO8859-1
02:51:58  [echoproperties] buildjdk.sun.management.compiler=HotSpot 64-Bit Tiered Compilers
02:51:58  [echoproperties] buildjdk.user.dir=/home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/aqa-systemtest/openjdk.build
02:51:58  [echoproperties] buildjdk.user.home=/home/jenkins
02:51:58  [echoproperties] buildjdk.user.language=en
02:51:58  [echoproperties] buildjdk.user.name=jenkins
02:51:58     [delete] Deleting: /tmp/openjdk.java.build.properties.631348112

Followed by the error run where deletion of the openjdk.java.build.properties file is earlier (too early?).

02:51:59  setup-java-properties:
02:51:59       [echo] java_home is ${java_home}
02:51:59       [echo] java.home is /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/jdkbinary/j2sdk-image
02:51:59  [echoproperties] #Ant properties
02:51:59  [echoproperties] #Fri Aug 09 06:51:59 GMT 2024
02:51:59  [echoproperties] buildjdk.Property=settings\:
02:51:59  [echoproperties] buildjdk.file.encoding=UTF-8
02:51:59  [echoproperties] buildjdk.file.separator=/
02:51:59  [echoproperties] buildjdk.jav=
02:51:59  [echoproperties] buildjdk.java.class.path=
02:51:59  [echoproperties] buildjdk.java.class.version=67.0
02:51:59     [delete] Deleting: /tmp/openjdk.java.build.properties.1864659393
02:52:00  
02:52:00  BUILD FAILED
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/TKG/scripts/build_test.xml:95: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/common.xml:392: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/common.xml:383: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/STF/stf.build/include/top.xml:83: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/STF/stf.build/include/top.xml:517: The following error occurred while executing this line:
02:52:00  /home/jenkins/workspace/Test_openjdk23_hs_extended.system_ppc64_aix_testList_0/aqa-tests/system/STF/stf.build/include/top.xml:576: java os.name property value ${buildjdk.os.name} not recognised.  Update the get-platform-prefix macrodef in stf.build/include/top.xml

[jiekang]

The setup-java-properties target has an unless field that seems to indicate it should only run once, but that does not seem to work here:

	<target name="setup-java-properties" unless="setup_java_properties_run">
		<property name="setup_java_properties_run" value="true"/>

https://github.com/adoptium/STF/blob/c21e789072cf5aa3f7cc58be5116da1024ffc5a0/stf.build/include/top.xml#L65

[jiekang]

Related: eclipse-openj9/openj9#18110

Same issue and same question about why setup-java-properties was run twice

[jiekang]

Running twice shouldn't result in this issue.

The relevant code is:
https://github.com/adoptium/STF/blob/master/stf.build/include/top.xml#L492-L510

It creates a temporary file, writes the output of $ java -XshowSettings:properties -version into the temporary file, reads from the temporary file into Ant properties, and then deletes the temporary file.

If it worked once, it should presumably work multiple times. The log output shows significantly less Ant properties were created on the second run.

For debugging, it would be nice to see the contents of the temporary file. Following that we'd need to see how the scopes are defined for the build process. Ant properties are immutable once set. And then other then that, given how intermittent it is, maybe there's a bug in Ant.

[smlambert]

For the record, we do not technically "need" STF. It is an extra layer of complexity (and somewhat circular dependencies) that are tricky to debug and could be eliminated (though this is low on the priority list at the moment). TKG could run the test materials in the aqa-systemtest and openj9-systemtest repos directly.

Additionally, the 2 systemtest repositories could be combined into a single repository, since playlists define what targets apply to what implementations. The decision to arbitrarily separate the 2 sets of tests was unnecessary, but unlikely worth the confusion to re-integrate.