Use LIBPATH Environment Variable to Run Serviceability JVMTI Tests

[Darshan-N3]

Use LIBPATH environment variable option to run serviceability jvmti tests

Signed-off-by: Darshan N [email protected]

[smlambert]

It is unclear why the -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native" option a few lines above this change is not sufficient to run this target. Is there a description of the problem in an issue somewhere to refer to?

[Darshan-N3]

It is unclear why the -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native" option a few lines above this change is not sufficient to run this target. Is there a description of the problem in an issue somewhere to refer to?

Hi @smlambert,
On z/OS, simply specifying nativepath is not enough for these tests. The libraries are getting picked from the LIBPATH environment variable instead, so this additional change is necessary to ensure the tests run correctly on z/OS. Thank you!

[smlambert]

On z/OS, simply specifying nativepath is not enough for these tests. The libraries are getting picked from the LIBPATH environment variable instead, so this additional change is necessary to ensure the tests run correctly on z/OS. Thank you!

A few notes to indicate why we should come at this in a different way:

• This change is currently being applied to all platforms, not just z/OS.
• There are a good deal more test targets besides serviceability_jvmti_j9 that utilize the native libraries, that presumably will also need to be running on z/OS in the future. It would be good to consider those future requirements.

I am wondering about making a change in the openjdk.mk file to achieve the desired outcome.
https://github.com/adoptium/aqa-tests/blob/master/openjdk/openjdk.mk#L184-L194

Since this will not affect hotspot testing, but will affect openj9 and semeru testing, I will request a review from @pshipton.

[pshipton]

@Darshan-N3 pls make the change specific to z/OS by checking and setting a variable in openjdk.mk as Shelley suggested.

[pshipton]

I also notice serviceability_jdwp_j9 has the same native library setting, perhaps it needs the same change.

On z/OS, simply specifying nativepath is not enough for these tests. The libraries are getting picked from the LIBPATH environment variable instead,

How does this work for any other playlist that uses native libraries?

[karianna]

whitepsace

[pshipton]

@smlambert is this change acceptable?

[smlambert]

Thanks @Darshan-N3

[smlambert]

Hmm, one other way would be to just replace JVM_NATIVE_OPTIONS with -e LIBPATH=$(TESTIMAGE_PATH)$(D)hotspot$(D)jtreg$(D)native for OS/390, if the other -nativepath piece is ignored anyway

but I am fine to proceed with this, as its been tested. If this moves to changing all of the native test targets in the playlist, we may take that opportunity to combine and set into an existing variable.