Skip to content

Conversation

@Haroon-Khel
Copy link
Contributor

duplicate of #1131 but uses https://ci.adoptium.net/job/sign_temurin_cyclonedx/ instead of https://ci.adoptium.net/job/build-scripts/job/release/job/sign_temurin_jsf/ to sign potential SBOM xml files

Like adoptium/temurin-build#4075 this pr depends on adoptium/temurin-build#4075 (comment)

Theres probably a better place to call the signSBOMCyclonedx() function than line 2451, feel free to point it out 👍🏻

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

}
}
}
private void signSBOMCyclonedx() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private void signSBOMCyclonedx() {
private void signSBOMCyclonedx() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants