-
-
Notifications
You must be signed in to change notification settings - Fork 75
add all hotspot variants so they are regenerated for trestle, remove third party variants #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…third-party variants Signed-off-by: Stewart X Addison <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
Failure appears to have beenin https://ci.adoptium.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk8u/job/jdk8u-windows-x64-temurin/23/console and is due to a permission denied error and locked files on (Issue raised - linked below this comment) |
Signed-off-by: Stewart X Addison <[email protected]>
|
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
As far as I can tell the builds passed but there was a Jenkins failure to report back some of the SUCCESS statuses |
Add
hotspotvariants to the configuration so those jobs are regenerated and kept up to date with a view to using them in project trestle.This is a follow on from the work to enable and test on a subset platforms at #1317 which has been shown to work as well as the Temurin pipelines.
This PR also removes most of the third party variants which we are no longer building (I've left them on x64 in case we want to test that our underlying code that supports those still works). We may wish to clarify whether Alibaba or Huawei are utilising our pipelines configurations in any way (I suspect not - OpenJ9 certainly are not as confirmed in the previous PR referenced above)
I was tempted to add in arm32/win32 as platforms for jdk25/26 to allow people using trestle to test on a 32-bit platform, and while that is feasible it would also require a suitable boot JDK to be made available which do not currently have on those platforms.