unixPB: Ensure en_US.UTF-8 locale is generated on CentOS for build images#4275
Open
sxa wants to merge 1 commit intoadoptium:masterfrom
Open
unixPB: Ensure en_US.UTF-8 locale is generated on CentOS for build images#4275sxa wants to merge 1 commit intoadoptium:masterfrom
sxa wants to merge 1 commit intoadoptium:masterfrom
Conversation
…ages Signed-off-by: Stewart X Addison <sxa@ibm.com>
| # Skipping linting as locale_gen module isn't usable on CentOS6/7 | ||
| # https://github.com/ansible/ansible/issues/44708 | ||
| - name: Create US UTF-8 locale | ||
| shell: localedef -i en_US -c -f UTF-8 en_US.UTF-8 |
Contributor
There was a problem hiding this comment.
I note the OpenJDK make first checks for C.utf8 (ref: https://github.com/adoptium/jdk25u/blob/30a962c1ab3ef19159c3ea2179602289e7e6f3ac/make/autoconf/basic.m4#L139)
and then drops back to en_US.UTF-8
Should we alias to "C.utf8" ?
Member
Author
There was a problem hiding this comment.
Should we alias to "C.utf8" ?
If that's possible then sure :-)
Also bear in mind that C.utf8 is not in the locales for the Linux/x64 image and we should probably strive for compatibility one way or another, and so we should be careful with testing if we're going to change such a default everywhere.
sxa
changed the title
Contributor
|
Reproducibility across OS distributions maybe a consideration here? see #4284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #3576 and resolves a difference between the x64 image and the aarch64 one. Note that with this change the
configureerror is suppressed whenLC_ALL=en_US.utf8is in the environment (although a warning is generated when you set that variable):Checklist