Skip to content

Commit ee63d39

Browse files
committed
Simplified the condition
1 parent aecbf09 commit ee63d39

File tree

1 file changed

+24
-22
lines changed

1 file changed

+24
-22
lines changed

sbin/build.sh

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -548,39 +548,41 @@ configureAlsaLocation() {
548548
fi
549549
}
550550

551-
setFreeTypePerJdk8Tag() {
551+
getFreeTypePerJdk8Tag() {
552552
if [ -n "${BUILD_CONFIG[TAG]}" ]; then
553553
local majorBuildVersion=$(echo "${BUILD_CONFIG[TAG]}" | sed "s/jdk8u//" | sed "s/-.*//")
554-
if [ 0${majorBuildVersion} -lt 482 ] ; then
555-
if [ "${1}" == "srcs" ] ; then
556-
setFreeTypeFromSrcs
557-
elif [ "${1}" == "installed" ] ; then
558-
setFreeTypeFromInstalled
559-
else
560-
echo "invalid parameter $1"
561-
exit 1
562-
fi
554+
if [ 0${majorBuildVersion} -lt 482 ] ; then
555+
echo "old"
563556
elif [ 0${majorBuildVersion} -gt 482 ] ; then
564-
setDefaultFreeType
557+
echo "new"
565558
else
566559
# the change was introduces in 482, lets determine the build promotion, and decide
567560
local minorBuildNumber=$(echo "${BUILD_CONFIG[TAG]}" | sed "s/.*-//" | sed "s/[^0-9]//g")
568561
# if the number is empty, is probably ga, so ok to use newest
569-
if [ "x${minorBuildNumber}" = "x" ] || [ 0${minorBuildNumber} -ge 01 ] ; then #FIXME, replace by real b's number once merged
570-
setDefaultFreeType
562+
if [ -z "${minorBuildNumber}" ] || [ 0${minorBuildNumber} -ge 01 ] ; then #FIXME, replace by real b's number once merged
563+
echo "new"
571564
else
572-
if [ "${1}" == "srcs" ] ; then
573-
setFreeTypeFromSrcs
574-
elif [ "${1}" == "installed" ] ; then
575-
setFreeTypeFromInstalled
576-
else
577-
echo "invalid parameter $1"
578-
exit 1
579-
fi
565+
echo "old"
580566
fi
581567
fi
582568
else
583-
# no tag, treating as newest, so bundled
569+
# no tag, treating as newest
570+
echo "new"
571+
fi
572+
}
573+
574+
setFreeTypePerJdk8Tag() {
575+
local jdk8Type="$(getFreeTypePerJdk8Tag)"
576+
if [ "${jdk8Type}" = "old" ] ; then
577+
if [ "${1}" = "srcs" ] ; then
578+
setFreeTypeFromSrcs
579+
elif [ "${1}" = "installed" ] ; then
580+
setFreeTypeFromInstalled
581+
else
582+
echo "invalid parameter $1"
583+
exit 1
584+
fi
585+
else
584586
setDefaultFreeType
585587
fi
586588
}

0 commit comments

Comments
 (0)