[JDK 24] jlink fails on Windows/Mac with '<binary-file> has been modified' error

[Thihup]

Using JLink with JDK 24 fails with:

Error: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\24.0.0-ea.24.0.ea\x64\bin\j2pkcs11.dll has been modified

Build link: https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24%2B24-ea-beta/OpenJDK-jdk_x64_windows_hotspot_24_24-ea.zip

[karianna]

Please report this upstream to OpenJDK - https://mail.openjdk.org/mailman/listinfo/core-libs-dev

[judovana]

It do not necessarily be an upstream bug. It can be really downstream. The jmod files and the dll files are bound together. If the signing (or any other operation after build) changes the dll, the jmods have to be adjusted.

Forgive me if the details are not exactly precise, as I was dealing with this on rpm level, and had to rebuild jmods after the build was done.

[sxa]

Interesting - are you getting the same failure with the nightly Temurin builds of 21 or 23 or is it specific to 24. Our signing process should be the same across all versions.

[judovana]

Interesting - are you getting the same failure with the nightly Temurin builds of 21 or 23 or is it specific to 24. Our signing process should be the same across all versions.

Hi! I can not provide much more info. I hit it during packing the October CPU, it may be even unrelated. But I hit the same "... .so has been modified". Please ping gnu_andrew/frederic They may know more. Especially if it can imapct windows packaging.

[judovana]

I forget to mention, that I hit it on all used .so files, not jsut j2pkcs11. So maybe the j2pkcs11 is new in jdk24 (which I think it is) and thus maybe some logic missed it?

[sxa]

This looks like it changed between 24+23 and 24+24 which was when we implemented the options for JEP493 in #4035

@jerboaa Is this expected? The error message doesn't feel right to me but you're in a better place to comment. I'll re-open until we're sure this is working as expected.

[jerboaa]

This looks like it changed between 24+23 and 24+24 which was when we implemented the options for JEP493 in #4035

@jerboaa Is this expected? The error message doesn't feel right to me but you're in a better place to comment. I'll re-open until we're sure this is working as expected.

@sxa It's not expected. The way JEP 493 detects modified files is by generating a 512 sha of the file at build time when jlink runs during the build. So if Temurin adds something to those DLLs (like a signature) after, it would consider them modified. I'm not clear how the signing of DLLs work and if that is needed.

FWIW, adding --verbose to the jlink invocation would say it's linking from the run-time image. If that's what it is, then it's caused by the change in #4035 and would need some fix to get the signing step properly working. Ideally, the signing would happen before the final run-time image is linked.

[jerboaa]

Aren't Mac OSX builds also doing some signing? Would those have a similar issue?

[jerboaa]

@Thihup As a work-around you might be able to use --ignore-modified-runtime which demotes the issue to a warning. I would only recommend using it if you are sure it's OK, though.