Skip to content

Commit 5343aac

Browse files
committed
fixup! tools: add benchmark runner to test-shared
1 parent 7b6ae64 commit 5343aac

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.github/workflows/test-shared.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ permissions:
6060

6161
jobs:
6262
build-tarball:
63-
if: github.event.pull_request.draft == false
63+
if: false
6464
name: ${{ github.event_name == 'workflow_dispatch' && 'Skipped job' || 'Build slim tarball' }}
6565
runs-on: ubuntu-24.04-arm
6666
steps:
@@ -191,7 +191,7 @@ jobs:
191191
run: |
192192
nix-shell \
193193
-I nixpkgs=./nixpkgs.nix \
194-
--pure --keep FILTER \
194+
--pure --keep FILTER --keep LC_ALL --keep LANG \
195195
--arg loadJSBuiltinsDynamically false \
196196
--arg ccache 'null' \
197197
--arg icu 'null' \
@@ -223,9 +223,11 @@ jobs:
223223
path: ${{ matrix.system }}.csv
224224

225225
aggregate-benchmark-results:
226-
needs: build
226+
# needs: build
227227
name: Aggregate benchmark results
228-
if: ${{ github.event_name == 'workflow_dispatch' }}
228+
# if: ${{ github.event_name == 'workflow_dispatch' }}
229+
permissions:
230+
actions: read
229231
runs-on: ubuntu-latest
230232
steps:
231233
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -242,6 +244,9 @@ jobs:
242244
pattern: csv-*
243245
merge-multiple: true
244246
path: raw-results
247+
github-token: ${{ secrets.GITHUB_TOKEN }}
248+
repository: aduh95/node
249+
run-id: 18449878864
245250

246251
- uses: cachix/install-nix-action@7be5dee1421f63d07e71ce6e0a9f8a4b07c2a487 # v31.6.1
247252
with:
@@ -251,7 +256,7 @@ jobs:
251256
run: |
252257
nix-shell \
253258
-I nixpkgs=./nixpkgs.nix \
254-
--pure \
259+
--pure --keep LC_ALL --keep LANG \
255260
--arg loadJSBuiltinsDynamically false \
256261
--arg ccache 'null' \
257262
--arg icu 'null' \

shell.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
pkgs.rPackages.ggplot2
4747
pkgs.rPackages.plyr
4848
pkgs.wrk
49-
],
49+
] ++ pkgs.lib.optional pkgs.stdenv.buildPlatform.isLinux pkgs.glibcLocales,
5050
extraConfigFlags ? [
5151
"--without-npm"
5252
"--debug-node"

0 commit comments

Comments
 (0)