fixup! build: add --shared-absl configure flag

Author: aduh95

tools/nix/absl.nix

@@ -0,0 +1,14 @@
+{ abseil-cpp, fetchgit }:
+
+let
+  # Values from deps/v8/DEPS - third_party/abseil-cpp
+  url = "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git";
+  rev = "3fb321d9764442ceaf2e17b6e68ab6b6836bc78a";
+  # Computed based on the above:
+  hash = "sha256-KpjXpyWp9x0cSmyh3uwn0fwKreHA0Cb8c0rD+RHYB80=";
+in
+abseil-cpp.overrideAttrs {
+  src = fetchgit {
+    inherit url rev hash;
+  };
+}

tools/nix/sharedLibDeps.nix

@@ -19,13 +19,7 @@
     zlib
     zstd
     ;
-  absl = (pkgs.abseil-cpp.overrideAttrs {
-    src = pkgs.fetchgit {
-      url = "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git";
-      rev = "3fb321d9764442ceaf2e17b6e68ab6b6836bc78a";
-      hash = "sha256-KpjXpyWp9x0cSmyh3uwn0fwKreHA0Cb8c0rD+RHYB80=";
-    };
-  }).dev;
+  absl = (pkgs.callPackage ./absl.nix { }).dev;
   cares = pkgs.c-ares;
   hdr-histogram = pkgs.hdrhistogram_c;
   http-parser = pkgs.llhttp;

tools/nix/update-absl-nix.sh

@@ -0,0 +1,83 @@
+#!/bin/sh
+
+set -ex
+
+CMD=${1:-check}
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
+DEPS_FILE="$REPO_ROOT/deps/v8/DEPS"
+NIX_DERIVATION="$SCRIPT_DIR/absl.nix"
+
+if [[ ! -f "$DEPS_FILE" ]]; then
+    echo "Error: deps/v8/DEPS not found at $DEPS_FILE" >&2
+    exit 1
+fi
+
+if [[ ! -f "$NIX_DERIVATION" ]]; then
+    echo "Error: absl.nix not found at $NIX_DERIVATION" >&2
+    exit 1
+fi
+
+echo "Extracting values from deps/v8/DEPS..."
+
+ABSEIL_SRC=$(awk '/^ *\u0027third_party[\u002f]abseil-cpp\u0027: \{$/{ getline; print }' "$DEPS_FILE")
+
+echo "$ABSEIL_SRC" | grep -q "^ \+'url': Var('chromium_url') + '.\+' + '@' + '.\+',$" || {
+  echo "Unexpected format for abseil-cpp source URL: $ABSEIL_SRC"
+  exit 1
+}
+
+REPO_URL="$(grep "^ \+'chromium_url':" "$DEPS_FILE" | awk -F"'" '{ print $4; }')$(echo "$ABSEIL_SRC" | awk -F"'" '{ print $6 }')"
+REV="$(echo "$ABSEIL_SRC" | awk -F"'" '{ print $10 }')"
+
+shouldComputeHash=$([ "$CMD" != "write" ] || echo 1)
+
+ACTUAL_REPO_URL=$(awk -F'"' '/^ *url *=/{ print $2; }' "$NIX_DERIVATION")
+if [ "$REPO_URL" != "$ACTUAL_REPO_URL" ]; then
+    echo >&2
+    echo "Repository URL doesn't match!" >&2
+    echo "Expected: $REPO_URL" >&2
+    echo "Got: $ACTUAL_REPO_URL" >&2
+    echo >&2
+    shouldComputeHash=1
+fi
+ACTUAL_REV=$(awk -F'"' '/^ *rev *=/{ print $2; }' "$NIX_DERIVATION")
+if [ "$REV" != "$ACTUAL_REV" ]; then
+    echo >&2
+    echo "Repository revision doesn't match!" >&2
+    echo "Expected: $REV" >&2
+    echo "Got: $ACTUAL_REV" >&2
+    echo >&2
+    shouldComputeHash=1
+fi
+
+if [ -z "$shouldComputeHash" ]; then
+    echo "Already up-to-date" >&2
+    exit 0
+fi
+
+command -v nix-shell > /dev/null || {
+    echo "nix-shell is not available, cannot compute expected hash" >&2
+    exit 1
+}
+HASH="$(REPO_URL="$REPO_URL" REV="$REV" nix-shell -I "nixpkgs=$SCRIPT_DIR/pkgs.nix" --pure --keep REPO_URL --keep REV -p nix-prefetch-git -p cacert -p nix -p jq --run 'nix-prefetch-git --url "$REPO_URL" --rev "$REV" | jq -r .hash')";
+tmp_file=$(mktemp)
+cat -> "$tmp_file" <<NIX
+$(awk '{ if ($0 == "let") { print; exit } else print }' "$NIX_DERIVATION")
+  # Values from deps/v8/DEPS - third_party/abseil-cpp
+  url = "$REPO_URL";
+  rev = "$REV";
+  # Computed based on the above:
+  hash = "$HASH";
+$(awk 'flag || /^in$/{flag=1} flag{print $0}' "$NIX_DERIVATION")
+NIX
+if [ "$CMD" != "write" ]; then
+    echo "Apply the following diff to fix the issue:" >&2
+    REL=${NIX_DERIVATION#"$REPO_ROOT"/}
+    diff -u --label "a/$REL" --label "b/$REL" "$NIX_DERIVATION" "$tmp_file" || true
+    rm "$tmp_file"
+    exit 1
+fi
+mv "$tmp_file" "$NIX_DERIVATION"
+echo "$NIX_DERIVATION has been updated" >&2