Skip to content

Commit 98b6de2

Browse files
committed
fixup! tools: add benchmark runner to test-shared
1 parent 7b6ae64 commit 98b6de2

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/workflows/test-shared.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ permissions:
6060

6161
jobs:
6262
build-tarball:
63-
if: github.event.pull_request.draft == false
6463
name: ${{ github.event_name == 'workflow_dispatch' && 'Skipped job' || 'Build slim tarball' }}
6564
runs-on: ubuntu-24.04-arm
6665
steps:
@@ -191,7 +190,7 @@ jobs:
191190
run: |
192191
nix-shell \
193192
-I nixpkgs=./nixpkgs.nix \
194-
--pure --keep FILTER \
193+
--pure --keep FILTER --keep LC_ALL --keep LANG \
195194
--arg loadJSBuiltinsDynamically false \
196195
--arg ccache 'null' \
197196
--arg icu 'null' \
@@ -251,7 +250,7 @@ jobs:
251250
run: |
252251
nix-shell \
253252
-I nixpkgs=./nixpkgs.nix \
254-
--pure \
253+
--pure --keep LC_ALL --keep LANG \
255254
--arg loadJSBuiltinsDynamically false \
256255
--arg ccache 'null' \
257256
--arg icu 'null' \

shell.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
pkgs.rPackages.ggplot2
4747
pkgs.rPackages.plyr
4848
pkgs.wrk
49-
],
49+
] ++ pkgs.lib.optional pkgs.stdenv.buildPlatform.isLinux pkgs.glibcLocales,
5050
extraConfigFlags ? [
5151
"--without-npm"
5252
"--debug-node"

0 commit comments

Comments
 (0)