Skip to content

Commit a1274f9

Browse files
author
Irina
committed
validation format change
1 parent 549efce commit a1274f9

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

Homepage.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import matplotlib.pyplot as plt
22
import requests
33
import streamlit as st
4+
from validation import eia_schema
45

56
from tests.eia_part3 import (
67
build_df_from_eia_data,
@@ -59,8 +60,6 @@ def fetch_supply_json(url: str) -> dict:
5960

6061
# Filter (2012–present)
6162
df = filter_since(df, date_col="week", start_date="2012-01-01")
62-
from tests.validation import eia_schema
63-
6463
df = eia_schema.validate(df)
6564

6665
weekly_total = sum_by_week(df, date_col="week", value_col="value")

tests/test_validation.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
import pandas as pd
2+
import pandera as pa
23
import pytest
34
from validation import eia_schema
45

56

67
def test_schema_rejects_negative_values():
7-
df = pd.DataFrame({
8-
"week": pd.to_datetime(["2012-01-06"]),
9-
"value": [-5]
10-
})
8+
df = pd.DataFrame(
9+
{
10+
"week": pd.to_datetime(["2012-01-06"]),
11+
"value": [-5],
12+
}
13+
)
14+
15+
with pytest.raises(pa.errors.SchemaError):
16+
eia_schema.validate(df)
1117

12-
with pytest.raises(Exception):
13-
eia_schema.validate(df)

tests/validation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"week": Column(pa.DateTime),
77
"value": Column(
88
pa.Float,
9-
coerce=True,
10-
checks=Check.ge(0),
9+
coerce=True,
10+
checks=Check.ge(0),
1111
nullable=False,
1212
),
1313
}

0 commit comments

Comments
 (0)