Skip to content

Commit 6128c45

Browse files
committed
fix: update deployment workflow to support Windows testing and upgrade Node.js version to 18
1 parent 223db6d commit 6128c45

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

.github/workflows/deployment.yml

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ jobs:
1818
fail-fast: false
1919
matrix:
2020
os: [ubuntu-20.04]
21-
# os: [ubuntu-18.04, ubuntu-20.04]
2221
runs-on: ${{ matrix.os }}
2322
steps:
2423
- uses: actions/checkout@v2
@@ -36,12 +35,31 @@ jobs:
3635
run: npm ci
3736
- name: Run tests
3837
run: npm test
38+
test_win:
39+
name: "Windows"
40+
runs-on: windows-latest
41+
steps:
42+
- uses: actions/checkout@v2
43+
- uses: actions/setup-node@v1
44+
with:
45+
node-version: 18
46+
- uses: microsoft/playwright-github-action@v1
47+
- uses: actions/cache@v3
48+
with:
49+
path: ~/.npm
50+
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
51+
restore-keys: |
52+
${{ runner.os }}-node-
53+
- name: Install dependencies
54+
run: npm ci
55+
- name: Run tests
56+
run: npm test
3957
tag:
4058
name: "Publishing release"
4159
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master'
42-
needs:
60+
needs:
4361
- test_linux
44-
# - test_win
62+
- test_win
4563
runs-on: ubuntu-latest
4664
steps:
4765
- name: Checkout code
@@ -50,7 +68,7 @@ jobs:
5068
fetch-depth: 0
5169
- uses: actions/setup-node@v2
5270
with:
53-
node-version: '16.x'
71+
node-version: '18.x'
5472
registry-url: 'https://registry.npmjs.org'
5573
- uses: actions/cache@v3
5674
with:

0 commit comments

Comments
 (0)