Skip to content

Commit 3914897

Browse files
committed
Update: Updated settings for analytics
1 parent c5902d1 commit 3914897

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

bower.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"app-pouchdb-collate": "advanced-rest-client/app-pouchdb-collate#^1.0.1",
2626
"app-logger": "advanced-rest-client/app-logger#^0.1.0",
2727
"app-log-viewer": "advanced-rest-client/app-log-viewer#^0.1.0",
28-
"app-analytics": "advanced-rest-client/app-analytics#^1.0.5",
28+
"app-analytics": "advanced-rest-client/app-analytics#^1.1.1",
2929
"date-time": "advanced-rest-client/date-time#^0.1.2",
3030
"network-state": "advanced-rest-client/network-state#^0.1.1",
3131
"arc-loader-screen": "advanced-rest-client/arc-loader-screen#^0.1.1",
@@ -53,7 +53,7 @@
5353
"websocket-panel": "advanced-rest-client/websocket-panel#^0.1.1",
5454
"chrome-file-export": "advanced-rest-client/chrome-file-export#^0.1.1",
5555
"arc-chrome-settings": "advanced-rest-client/arc-chrome-settings#^0.1.1",
56-
"arc-settings-panel": "advanced-rest-client/arc-settings-panel#^0.1.1",
56+
"arc-settings-panel": "advanced-rest-client/arc-settings-panel#^0.2.1",
5757
"saved-requests-panel": "advanced-rest-client/saved-requests-panel#^0.1.1",
5858
"google-drive-browser": "advanced-rest-client/google-drive-browser#^0.1.1",
5959
"arc-data-import": "advanced-rest-client/arc-data-import#^0.1.1",

src/arc-electron.html

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -163,23 +163,23 @@
163163
<paper-toast id="offlineToast" class="offline-toast" text="You are now offline. Can't make new requests."></paper-toast>
164164
<search-bar id="content-search-bar" on-iron-overlay-opened="textSearchBarOpened"></search-bar>
165165
<template is="dom-if" if="[[telemetry]]" restamp="true">
166-
<app-analytics tracking-id="UA-18021184-6" app-name="ARC-electon" app-id="[[appId]]" app-version="[[appVersion]]" disable-tracking="{{analyticsDisabled}}" data-source="electron-app">
166+
<app-analytics tracking-id="UA-18021184-6" app-name="ARC-electon" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
167167
<template is="dom-repeat" items="[[gaCustomMetrics]]">
168168
<app-analytics-custom type="metric" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
169169
</template>
170170
<template is="dom-repeat" items="[[gaCustomDimensions]]">
171171
<app-analytics-custom type="dimension" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
172172
</template>
173173
</app-analytics>
174-
<app-analytics tracking-id="UA-18021184-14" app-name="ARC" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app" disable-tracking="{{analyticsDisabled}}">
174+
<app-analytics tracking-id="UA-18021184-14" app-name="ARC" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
175175
<template is="dom-repeat" items="[[gaCustomMetrics]]">
176176
<app-analytics-custom type="metric" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
177177
</template>
178178
<template is="dom-repeat" items="[[gaCustomDimensions]]">
179179
<app-analytics-custom type="dimension" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
180180
</template>
181181
</app-analytics>
182-
<app-analytics tracking-id="UA-71458341-2" app-name="ARC" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app" disable-tracking="{{analyticsDisabled}}">
182+
<app-analytics tracking-id="UA-71458341-2" app-name="ARC" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
183183
<template is="dom-repeat" items="[[gaCustomMetrics]]">
184184
<app-analytics-custom type="metric" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
185185
</template>
@@ -248,17 +248,6 @@
248248
accessToken: String,
249249
// Latest update event data
250250
updateState: Array,
251-
/**
252-
* Overrides analytics element behavior.
253-
* This setting is now in main application settings.
254-
*
255-
* TODO: Remove state setting from the element. This should be
256-
* controlled from the outside.
257-
*/
258-
analyticsDisabled: {
259-
type: Boolean,
260-
value: false
261-
},
262251
/**
263252
* Sets Google Analytics state. If this is not set or falsy, then Google
264253
* Analytics is diosabled (element is removed from the DOM).

0 commit comments

Comments
 (0)