Fix: Fixed version name change in main menu

Author: jarrodek

app/menus/darwin.json

@@ -3,7 +3,7 @@
       "label": "ARC",
       "submenu": [
         {"label": "About ARC", "command": "application:about"},
-        {"label": "Version", "enabled": false},
+        {"label": "VERSION", "enabled": false},
         {"label": "Restart and Install Update", "command": "application:install-update", "visible": false},
         {"label": "Check for Update", "command": "application:check-for-update", "visible": false},
         {"label": "Checking for Update", "enabled": false, "visible": false},

app/menus/win.json

@@ -45,7 +45,7 @@
         "label": "Help",
         "role": "help",
         "submenu": [
-          {"label": "Version", "enabled": false},
+          {"label": "VERSION", "enabled": false},
           {"label": "Restart and Install Update", "command": "application:install-update", "visible": false},
           {"label": "Check for Update", "command": "application:check-for-update", "visible": false},
           {"label": "Checking for Update", "enabled": false, "visible": false},

app/scripts/main-menu.js

@@ -18,7 +18,6 @@ class ArcMainMenu extends EventEmitter {
     this._getTemplate()
     .then(template => this._createFromTemplate(template))
     .then(() => Menu.setApplicationMenu(this.topMenu))
-    .then(() => this.updateVersion())
     .catch(cause => {
       let message = 'Menu template file was not found.';
       console.error(message);
@@ -99,27 +98,6 @@ class ArcMainMenu extends EventEmitter {
     }
   }
 
-  updateVersion() {
-    var name = this._platformToName(process.platform);
-    var version = app.getVersion();
-    this['_' + name + 'UpdateVersion'](version);
-  }
-
-  _darwinUpdateVersion(version) {
-    var item = this.topMenu.items[0].submenu.items[0];
-    item.label = 'Version: ' + version;
-  }
-
-  _winUpdateVersion(version) {
-    var item = this.topMenu.items[3].submenu[0];
-    item.label = 'Version: ' + version;
-  }
-
-  _linuxUpdateVersion(version) {
-    var item = this.topMenu.items[3].submenu[0];
-    item.label = 'Version: ' + version;
-  }
-
   _itemAction(command, menuItem, browserWindow) {
     this.emit('menu-action', command, browserWindow);
   }
@@ -144,6 +122,9 @@ class ArcMainMenu extends EventEmitter {
     if (options.submenu) {
       options.submenu = this._createSubMenu(options.submenu);
     }
+    if (options.label === 'VERSION') {
+      options.label = 'Version: ' + app.getVersion();
+    }
     return new MenuItem(options);
   }