chore: adding type check when accessing a property

jarrodek · jarrodek · commit 5ebf9d79326c · 2021-12-16T18:26:09.000-08:00
Signed-off-by: Pawel Psztyc &lt;jarrodek@gmail.com&gt;
diff --git a/src/io/defaults/ThemeDefaults.js b/src/io/defaults/ThemeDefaults.js
@@ -209,11 +209,11 @@ export class ThemeDefaults {
       // version 0
       return this._upgradeInfoFile(file, data);
     }
-    if (!(data.themes instanceof Array)) {
+    if (!Array.isArray(data.themes)) {
       return this._copyInfoFile();
     }
     const item = data.themes[0];
-    if (!item.location) {
+    if (!item || !item.location) {
       return this._copyInfoFile();
     }
     if ((item.mainFile || '').indexOf('.js') !== -1) {

Original file line number	Diff line number	Diff line change
`@@ -209,11 +209,11 @@ export class ThemeDefaults {`
`209`	`209`	`// version 0`
`210`	`210`	`return this._upgradeInfoFile(file, data);`
`211`	`211`	`}`
`212`		`- if (!(data.themes instanceof Array)) {`
	`212`	`+ if (!Array.isArray(data.themes)) {`
`213`	`213`	`return this._copyInfoFile();`
`214`	`214`	`}`
`215`	`215`	`const item = data.themes[0];`
`216`		`- if (!item.location) {`
	`216`	`+ if (!item \|\| !item.location) {`
`217`	`217`	`return this._copyInfoFile();`
`218`	`218`	`}`
`219`	`219`	`if ((item.mainFile \|\| '').indexOf('.js') !== -1) {`