chore: refactor to reuse configuration object

Author: jarrodek

app.js

@@ -125,29 +125,32 @@ class ArcInit {
     }
     this.initConfig = initConfig;
     window.ArcConfig.initConfig = initConfig;
-    await this.initApp();
-    await this.upgradeApp();
+
+    let cnf;
+    try {
+      cnf = await this.prefProxy.load();
+      await this._createApp(cnf);
+    } catch (e) {
+      this.reportFatalError(e);
+      throw e;
+    }
+
+    await this.initApp(cnf);
+    await this.upgradeApp(cnf);
     await this.processInitialPath();
     await this.removeLoader();
     console.log('Application window is now ready.');
   }
   /**
    * Initialized the application when window is ready.
    *
+   * @param {Object} cnf Current qapplication configuration
    * @return {Promise}
    */
-  async initApp() {
+  async initApp(cnf) {
     // console.info('Initializing renderer window...');
     this.workspaceManager = new WorkspaceManager(this.initConfig.workspaceFile);
     this.workspaceManager.observe();
-    let cnf;
-    try {
-      cnf = await this.prefProxy.load();
-      await this._createApp(cnf);
-    } catch (e) {
-      this.reportFatalError(e);
-      throw e;
-    }
     if (this.initConfig.darkMode) {
       cnf.theme = '@advanced-rest-client/arc-electron-dark-theme';
     }
@@ -431,8 +434,7 @@ class ArcInit {
     }, 150);
   }
 
-  async upgradeApp() {
-    const cnf = await this.prefProxy.load();
+  async upgradeApp(cnf) {
     const inst = new UpgradeHelper(cnf.upgrades);
     const upgrades = inst.getUpgrades();
     if (!upgrades || upgrades.length === 0) {