fix: fixes #205 - dark theme styling and theme manager logic

Author: jarrodek

.vscode/launch.json

@@ -10,7 +10,7 @@
       "windows": {
         "runtimeExecutable": "${workspaceRoot}/node_modules/.bin/electron.cmd"
       },
-      "args" : ["."]
+      "args" : [".", "--debug", "--debug-level=\"silly\"", "--workspace-path=\"~/arc-dev/workspace\"", "--settings-file=\"~/arc-dev/dev-settings.json\"", "--themes-path=\"~/arc-dev/themes-esm\""] 
     }
   ]
-}
+}

app.html

@@ -14,7 +14,6 @@
     font-family: 'Roboto', 'Noto', sans-serif;
     color: #333;
     margin: 0;
-    font-size: 100%;
     line-height: 1.5;
     background-color: var(--arc-bg-color);
     -webkit-user-select: none;
@@ -26,6 +25,7 @@
   html, body {
     height: 100%;
     margin: 0;
+    font-size: 15px;
   }
 
   .loader {

appresources/themes/@advanced-rest-client/arc-electron-anypoint-theme/arc-electron-anypoint-theme.css

@@ -187,7 +187,7 @@ body {
   --warning-contrast-color: #fff;
   --pages-fixed-height: calc(100vh - 64px);
   --arc-menu-height: 100%;
-  --arc-toolbar-color: #ffffff;
+  --arc-toolbar-color: #000;
   --arc-toolbar-background-color: var(--anypoint-color-steel5);
   --arc-toolbar-environment-selector-input-color: var(--anypoint-color-tertiary);
   --arc-toolbar-paper-icon-button-active-color: var(--anypoint-color-tertiary);
@@ -334,9 +334,12 @@ body {
 
   --variables-preview-overlay-background-color: var(--primary-background-color);
   --arc-env-container-color: #000;
-  --arc-toolbar-variables-toggle-icon-color: #000;
-  --arc-toolbar-back-icon-color: #000;
   --arc-env-selector-background-color: transparent;
   --arc-env-selector-color: #000;
-  --arc-toolbar-icon-color: #fff;
+
+  --arc-toolbar-variables-toggle-icon-color: #000;
+  --arc-toolbar-back-icon-color: #000;
+  --arc-toolbar-icon-color: #000;
+
+  --anypoint-item-hover-background-color: #EEEEEE;
 }

appresources/themes/@advanced-rest-client/arc-electron-dark-theme/arc-electron-dark-theme.css

@@ -1,4 +1,8 @@
 body {
+  background-color: #424242;
+  height: 100vh;
+  color: #fff;
+
   --arc-font-family: 'Roboto', 'Noto', sans-serif;
   --arc-font-font-smoothing: antialiased;
   --arc-font-code-family: 'Roboto Mono', 'Consolas', 'Menlo', monospace;
@@ -41,9 +45,6 @@ body {
   --select-text-user-select: text;
   --select-text-cursor: text;
 
-  background-color: #424242;
-  height: 100vh;
-  color: #fff;
   --primary-color: #BBDEFB;
   --primary-text-color: #fff;
   --error-color: #FF5722;
@@ -183,6 +184,13 @@ body {
   --api-console-menu-color: #fff;
 
   --api-endpoint-documentation-bottom-navigation-color: #fff;
+  --api-navigation-section-title-focus-background-color: #616161;
+  --api-endpoint-documentation-tryit-background-color: #424242;
+  --api-endpoint-documentation-tryit-panels-background-color: #424242;
+  --api-type-document-property-color: #fff;
+  --api-endpoint-documentation-description-color: #fff;
+  --api-body-document-code-color: #fff;
+
 
   --arc-menu-color: #fff;
   --request-list-item-history-group-header-color: #fff;
@@ -248,6 +256,10 @@ body {
   --arc-toolbar-variables-toggle-icon-color: #fff;
   --arc-toolbar-back-icon-color: #fff;
   --arc-toolbar-icon-color: #fff;
+  --arc-toolbar-button-background-color: #212121;
+
+  --about-arc-version-label-color: #fff;
+  --about-arc-updates-section-background-color: #424242;
 }
 
 body[narrow] {

appresources/themes/@advanced-rest-client/arc-electron-default-theme/README.md

@@ -0,0 +1,5 @@
+# arc-electron-default-theme
+
+Default theme definition for Advanced REST Client - desktop client.
+
+This package is installed by ARC automatically when new version is released.

appresources/themes/@advanced-rest-client/arc-electron-default-theme/package.json

@@ -1,24 +1,31 @@
 {
   "name": "@advanced-rest-client/arc-electron-default-theme",
-  "description": "A default theme definition for Advanced REST Client",
-  "version": "3.0.2",
+  "description": "Default theme definition for Advanced REST Client",
+  "version": "3.0.4",
   "license": "Apache-2.0",
   "main": "arc-electron-default-theme.css",
+  "keywords": [
+    "arc",
+    "theme"
+  ],
   "authors": [
     "Pawel Psztyc",
     "The Advanced REST client authors <[email protected]>"
   ],
-  "private": false,
-  "scripts": {
-    "lint": "polymer lint arc-electron-default-theme.html",
-    "test": "exit 0"
-  },
+  "contributors": [
+    "Pawel Psztyc",
+    "The Advanced REST client authors <[email protected]>"
+  ],
   "repository": {
     "type": "git",
     "url": "git://github.com/advanced-rest-client/arc-electron-default-theme.git"
   },
   "bugs": {
     "url": "https://github.com/advanced-rest-client/arc-electron-default-theme/issues",
     "email": "[email protected]"
+  },
+  "private": false,
+  "scripts": {
+    "test": "exit 0"
   }
 }

appresources/themes/themes-info.json

@@ -3,7 +3,7 @@
   "kind": "ARC#ThemeInfo",
   "themes": [
     {
-      "_id": "advanced-rest-client/arc-electron-default-theme",
+      "_id": "@advanced-rest-client/arc-electron-default-theme",
       "title": "Default theme",
       "name": "@advanced-rest-client/arc-electron-default-theme",
       "version": "3.0.2",
@@ -13,7 +13,7 @@
       "isDefault": true
     },
     {
-      "_id": "advanced-rest-client/arc-electron-anypoint-theme",
+      "_id": "@advanced-rest-client/arc-electron-anypoint-theme",
       "title": "Anypoint theme",
       "name": "@advanced-rest-client/arc-electron-anypoint-theme",
       "version": "3.0.2",
@@ -23,7 +23,7 @@
       "isDefault": true
     },
     {
-      "_id": "advanced-rest-client/arc-electron-dark-theme",
+      "_id": "@advanced-rest-client/arc-electron-dark-theme",
       "title": "Dark theme",
       "name": "@advanced-rest-client/arc-electron-dark-theme",
       "version": "3.0.2",