Skip to content

Commit e3a2143

Browse files
committed
Fix: Fixed analytics state change handler
1 parent b5468fb commit e3a2143

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/arc-electron.html

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,15 +171,15 @@
171171
<app-analytics-custom type="dimension" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
172172
</template>
173173
</app-analytics>
174-
<app-analytics tracking-id="UA-18021184-14" app-name="ARC" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
174+
<app-analytics tracking-id="UA-18021184-14" app-name="ARC-electon" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
175175
<template is="dom-repeat" items="[[gaCustomMetrics]]">
176176
<app-analytics-custom type="metric" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
177177
</template>
178178
<template is="dom-repeat" items="[[gaCustomDimensions]]">
179179
<app-analytics-custom type="dimension" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
180180
</template>
181181
</app-analytics>
182-
<app-analytics tracking-id="UA-71458341-2" app-name="ARC" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
182+
<app-analytics tracking-id="UA-71458341-2" app-name="ARC-electon" app-id="[[appId]]" app-version="[[appVersion]]" data-source="electron-app">
183183
<template is="dom-repeat" items="[[gaCustomMetrics]]">
184184
<app-analytics-custom type="metric" index="[[item.index]]" value="[[item.value]]"></app-analytics-custom>
185185
</template>
@@ -366,9 +366,6 @@
366366
* If changed setting is `telemetry` then it upodates GA state.
367367
*/
368368
_settingChanged: function(e) {
369-
if (e.cancelable) {
370-
return; // request for change
371-
}
372369
// Here we just care about `telemetry`
373370
if (e.detail.name !== 'telemetry') {
374371
return;

0 commit comments

Comments
 (0)