Skip to content

Commit dd9277e

Browse files
committed
Revert hack in ControlReference
1 parent af948b0 commit dd9277e

File tree

1 file changed

+10
-14
lines changed
  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5

1 file changed

+10
-14
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -343,20 +343,16 @@ class ControlReference extends Reference {
343343
string controlId;
344344

345345
ControlReference() {
346-
this.getArgument(0).getALocalSource().getStringValue() = controlId
347-
/*
348-
* and
349-
* (
350-
* exists(CustomController controller |
351-
* this = controller.getAViewReference().getAMemberCall("byId") or
352-
* this = controller.getAThisNode().getAMemberCall("byId")
353-
* )
354-
* or
355-
* exists(SapUiCore sapUiCore | this = sapUiCore.getAMemberCall("byId"))
356-
* )
357-
*/
358-
359-
}
346+
this.getArgument(0).getALocalSource().getStringValue() = controlId and
347+
(
348+
exists(CustomController controller |
349+
this = controller.getAViewReference().getAMemberCall("byId") or
350+
this = controller.getAThisNode().getAMemberCall("byId")
351+
)
352+
or
353+
exists(SapUiCore sapUiCore | this = sapUiCore.getAMemberCall("byId"))
354+
)
355+
}
360356

361357
CustomControl getDefinition() {
362358
exists(UI5Control controlDeclaration |

0 commit comments

Comments
 (0)