feat: Add commands to open files for selected results and flow steps, and improve data handling in ResultItem

Author: GeekMasher

src/extension.ts

@@ -127,6 +127,36 @@ export async function activate(context: vscode.ExtensionContext) {
             } else {
                 vscode.window.showWarningMessage('No flow steps available for this item.');
             }
+        }),
+        vscode.commands.registerCommand('codeql-scanner.resultSelected', async (resultData, uri, options) => {
+            try {
+                const document = await vscode.workspace.openTextDocument(uri);
+                const editor = await vscode.window.showTextDocument(document);
+                
+                if (options && options.selection) {
+                    editor.selection = new vscode.Selection(options.selection.start, options.selection.end);
+                    editor.revealRange(options.selection, vscode.TextEditorRevealType.InCenter);
+                }
+            } catch (error) {
+                const logger = LoggerService.getInstance();
+                logger.error('Command', 'Failed to open file for result', error);
+                vscode.window.showErrorMessage(`Failed to open file: ${error instanceof Error ? error.message : String(error)}`);
+            }
+        }),
+        vscode.commands.registerCommand('codeql-scanner.flowStepSelected', async (flowStepData, uri, options) => {
+            try {
+                const document = await vscode.workspace.openTextDocument(uri);
+                const editor = await vscode.window.showTextDocument(document);
+                
+                if (options && options.selection) {
+                    editor.selection = new vscode.Selection(options.selection.start, options.selection.end);
+                    editor.revealRange(options.selection, vscode.TextEditorRevealType.InCenter);
+                }
+            } catch (error) {
+                const logger = LoggerService.getInstance();
+                logger.error('Command', 'Failed to open file for flow step', error);
+                vscode.window.showErrorMessage(`Failed to open file: ${error instanceof Error ? error.message : String(error)}`);
+            }
         })
     ];
 

src/providers/resultsProvider.ts

@@ -675,11 +675,20 @@ export class ResultItem extends vscode.TreeItem {
         const logger = LoggerService.getInstance();
 
         if (this.type === 'result' && this.result) {
+            // Extract only the necessary properties instead of passing 'this'
+            const resultData = {
+                type: this.type,
+                result: this.result,
+                // Include other necessary properties but avoid circular references
+                language: this.language,
+                severity: this.severity
+            };
+            
             return {
                 command: 'codeql-scanner.resultSelected',
                 title: 'Open File',
                 arguments: [
-                    this,
+                    resultData,
                     vscode.Uri.file(this.result.location.file),
                     {
                         selection: new vscode.Range(
@@ -692,11 +701,18 @@ export class ResultItem extends vscode.TreeItem {
                 ]
             };
         } else if (this.type === 'flowStep' && this.flowStep) {
+            // Extract only the necessary properties instead of passing 'this'
+            const flowStepData = {
+                type: this.type,
+                flowStep: this.flowStep,
+                result: this.result
+            };
+            
             return {
                 command: 'codeql-scanner.flowStepSelected',
                 title: 'Open Flow Step',
                 arguments: [
-                    this,
+                    flowStepData,
                     vscode.Uri.file(this.flowStep.file),
                     {
                         selection: new vscode.Range(

src/providers/uiProvider.ts

@@ -301,78 +301,6 @@ export class UiProvider implements vscode.WebviewViewProvider {
     }
   }
 
-  private async autoLoadLanguagesIfNeeded() {
-    this.logger.logServiceCall(
-      "UiProvider",
-      "autoLoadLanguagesIfNeeded",
-      "started"
-    );
-
-    try {
-      // Check if languages are already configured
-      const config = vscode.workspace.getConfiguration("codeql-scanner");
-      const configuredLanguages = config.get<string[]>("languages", []);
-
-      if (configuredLanguages.length > 0) {
-        this.logger.debug(
-          "UiProvider",
-          `Languages already configured: ${configuredLanguages.join(", ")}`
-        );
-        return;
-      }
-
-      // If no CodeQL service is available, can't auto-load
-      if (!this._codeqlService) {
-        this.logger.debug(
-          "UiProvider",
-          "CodeQL service not available for auto-loading languages"
-        );
-        return;
-      }
-
-      this.logger.info(
-        "UiProvider",
-        "No languages configured, attempting to auto-load supported languages"
-      );
-
-      // Try to get supported languages from CodeQL CLI
-      await this._codeqlService.getSupportedLanguages();
-      const supportedLanguages = this._codeqlService.getLanguages();
-
-      if (supportedLanguages.length > 0) {
-        this.logger.info(
-          "UiProvider",
-          `Auto-loaded ${
-            supportedLanguages.length
-          } supported languages: ${supportedLanguages.join(", ")}`
-        );
-
-        // Send the languages to the webview for display
-        this._view?.webview.postMessage({
-          command: "supportedLanguagesLoaded",
-          success: true,
-          languages: supportedLanguages,
-          message: `Auto-loaded ${supportedLanguages.length} supported languages`,
-        });
-
-        this.logger.logServiceCall(
-          "UiProvider",
-          "autoLoadLanguagesIfNeeded",
-          "completed",
-          { languageCount: supportedLanguages.length }
-        );
-      } else {
-        this.logger.warn(
-          "UiProvider",
-          "No supported languages found during auto-load"
-        );
-      }
-    } catch (error) {
-      this.logger.warn("UiProvider", "Failed to auto-load languages", error);
-      // Don't show error to user for auto-loading, just log it
-    }
-  }
-
   private async autoSelectGitHubLanguages(): Promise<string[]> {
     this.logger.logServiceCall(
       "UiProvider",
@@ -570,7 +498,9 @@ export class UiProvider implements vscode.WebviewViewProvider {
         message:
           alert.message?.text || alert.rule?.description || "No description",
         location: {
-          file: alert.most_recent_instance?.location?.path || "unknown",
+          file: alert.most_recent_instance?.location?.path 
+            ? path.join(vscode.workspace.workspaceFolders?.[0]?.uri.fsPath || "", alert.most_recent_instance.location.path)
+            : "unknown",
           startLine: alert.most_recent_instance?.location?.start_line || 1,
           startColumn: alert.most_recent_instance?.location?.start_column || 1,
           endLine: alert.most_recent_instance?.location?.end_line || 1,