CDR : Add needs_validation in CDRProduct (#791)

### Description

Please explain the changes you made here.

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary

Author: Malem38

app/modules/cdr/cruds_cdr.py

@@ -178,8 +178,15 @@ async def update_product(
         .values(
             **product.model_dump(
                 exclude_none=True,
-                exclude={"product_constraints", "document_constraints"},
+                exclude={
+                    "product_constraints",
+                    "document_constraints",
+                    "related_membership",
+                },
             ),
+            related_membership_id=product.related_membership.id
+            if product.related_membership
+            else None,
         ),
     )
 
@@ -895,7 +902,19 @@ async def delete_customdata(db: AsyncSession, field_id: UUID, user_id: str):
 
 async def get_pending_validation_users(db: AsyncSession) -> Sequence[CoreUser]:
     result = await db.execute(
-        select(models_cdr.Purchase).where(models_cdr.Purchase.validated.is_(False)),
+        select(models_cdr.Purchase)
+        .join(
+            models_cdr.ProductVariant,
+            models_cdr.Purchase.product_variant_id == models_cdr.ProductVariant.id,
+        )
+        .join(
+            models_cdr.CdrProduct,
+            models_cdr.ProductVariant.product_id == models_cdr.CdrProduct.id,
+        )
+        .where(
+            models_cdr.Purchase.validated.is_(False),
+            models_cdr.CdrProduct.needs_validation.is_(True),
+        ),
     )
     user_ids = set(purchase.user_id for purchase in result.scalars().all())
     result_users = await db.execute(select(CoreUser).where(CoreUser.id.in_(user_ids)))

app/modules/cdr/endpoints_cdr.py

@@ -728,6 +728,7 @@ async def create_product(
         name_fr=product.name_fr,
         name_en=product.name_en,
         available_online=product.available_online,
+        needs_validation=product.needs_validation,
         description_fr=product.description_fr,
         description_en=product.description_en,
         related_membership_id=product.related_membership.id
@@ -923,6 +924,11 @@ async def create_product_variant(
             status_code=403,
             detail="CDR is closed. You cant add a new product.",
         )
+    if product and not product.needs_validation and product_variant.price != 0:
+        raise HTTPException(
+            status_code=403,
+            detail="A product that does not need validation must be free.",
+        )
     db_product_variant = models_cdr.ProductVariant(
         id=uuid4(),
         product_id=product_id,
@@ -1032,6 +1038,15 @@ async def update_product_variant(
             status_code=403,
             detail="This product has no related membership. You can't specify a membership duration.",
         )
+    if (
+        product_variant.price is not None
+        and db_product
+        and (not db_product.needs_validation and product_variant.price != 0)
+    ):
+        raise HTTPException(
+            status_code=403,
+            detail="A product that does not need validation must be free.",
+        )
 
     await cruds_cdr.update_product_variant(
         variant_id=variant_id,
@@ -1266,6 +1281,7 @@ async def get_purchases_by_user_id(
                                 name_fr=product.name_fr,
                                 name_en=product.name_en,
                                 available_online=product.available_online,
+                                needs_validation=product.needs_validation,
                                 description_fr=product.description_fr,
                                 description_en=product.description_en,
                                 related_membership=schemas_memberships.MembershipSimple(
@@ -1354,6 +1370,7 @@ async def get_purchases_by_user_id_by_seller_id(
                                 name_fr=product.name_fr,
                                 name_en=product.name_en,
                                 available_online=product.available_online,
+                                needs_validation=product.needs_validation,
                                 description_fr=product.description_fr,
                                 description_en=product.description_en,
                                 related_membership=schemas_memberships.MembershipSimple(
@@ -1562,7 +1579,7 @@ async def mark_purchase_as_validated(
         db=db,
         product_id=product_variant.product_id,
     )
-    if not product:
+    if not product or not product.needs_validation:
         raise HTTPException(
             status_code=404,
             detail="Invalid product.",

app/modules/cdr/models_cdr.py

@@ -76,6 +76,8 @@ class CdrProduct(Base):
     name_en: Mapped[str | None]
     available_online: Mapped[bool]
 
+    needs_validation: Mapped[bool]
+
     description_fr: Mapped[str | None] = mapped_column(default=None)
     description_en: Mapped[str | None] = mapped_column(default=None)
     related_membership_id: Mapped[uuid.UUID | None] = mapped_column(

app/modules/cdr/schemas_cdr.py

@@ -131,6 +131,7 @@ class ProductBase(BaseModel):
     description_fr: str | None = None
     description_en: str | None = None
     available_online: bool
+    needs_validation: bool = True
     related_membership: schemas_memberships.MembershipSimple | None = None
     tickets: list[GenerateTicketBase] = []
     product_constraints: list[UUID]
@@ -143,6 +144,7 @@ class ProductCompleteNoConstraint(BaseModel):
     description_fr: str | None = None
     description_en: str | None = None
     available_online: bool
+    needs_validation: bool
     id: UUID
     seller_id: UUID
     variants: list[ProductVariantComplete] = []
@@ -158,6 +160,7 @@ class ProductComplete(BaseModel):
     description_fr: str | None = None
     description_en: str | None = None
     available_online: bool
+    needs_validation: bool
     id: UUID
     seller_id: UUID
     variants: list[ProductVariantComplete] = []

migrations/versions/36_add_product_needs_validation.py

@@ -0,0 +1,46 @@
+"""add product needs_validation
+
+Create Date: 2025-08-18 16:04:30.438478
+"""
+
+from collections.abc import Sequence
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from pytest_alembic import MigrationContext
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision: str = "98e2557c00c8"
+down_revision: str | None = "7da0e98a9e32"
+branch_labels: str | Sequence[str] | None = None
+depends_on: str | Sequence[str] | None = None
+
+
+def upgrade() -> None:
+    op.add_column(
+        "cdr_product",
+        sa.Column("needs_validation", sa.Boolean(), nullable=True),
+    )
+    op.execute("UPDATE cdr_product SET needs_validation = true")
+    op.alter_column("cdr_product", "needs_validation", nullable=False)
+
+
+def downgrade() -> None:
+    op.drop_column("cdr_product", "needs_validation")
+
+
+def pre_test_upgrade(
+    alembic_runner: "MigrationContext",
+    alembic_connection: sa.Connection,
+) -> None:
+    pass
+
+
+def test_upgrade(
+    alembic_runner: "MigrationContext",
+    alembic_connection: sa.Connection,
+) -> None:
+    pass

tests/test_cdr.py

@@ -132,6 +132,7 @@ async def init_objects():
         description_fr="Un Produit",
         description_en="A Product",
         available_online=False,
+        needs_validation=True,
     )
     await add_object_to_db(product)
 
@@ -144,6 +145,7 @@ async def init_objects():
         description_fr="Un Produit disponible en ligne",
         description_en="An online available Product",
         available_online=True,
+        needs_validation=True,
     )
     await add_object_to_db(online_product)
 
@@ -154,6 +156,7 @@ async def init_objects():
         name_fr="Produit sans variante",
         name_en="Unused product",
         available_online=False,
+        needs_validation=True,
     )
     await add_object_to_db(empty_product)
 
@@ -164,6 +167,7 @@ async def init_objects():
         name_fr="Produit utilisable",
         name_en="Usable product",
         available_online=False,
+        needs_validation=True,
     )
     await add_object_to_db(usable_product)
 
@@ -331,6 +335,7 @@ async def init_objects():
         name_fr="Produit a ticket",
         name_en="Usable product",
         available_online=False,
+        needs_validation=True,
     )
     await add_object_to_db(ticket_product)
 
@@ -2444,6 +2449,7 @@ async def test_validate_purchase(client: TestClient):
         name_en="Product",
         available_online=False,
         related_membership_id=association_membership.id,
+        needs_validation=True,
     )
     await add_object_to_db(product_membership)
     product_membership_to_purchase = models_cdr.CdrProduct(
@@ -2453,6 +2459,7 @@ async def test_validate_purchase(client: TestClient):
         name_en="Product",
         available_online=False,
         related_membership_id=association_membership.id,
+        needs_validation=True,
     )
     await add_object_to_db(product_membership_to_purchase)
     product_2 = models_cdr.CdrProduct(
@@ -2461,6 +2468,7 @@ async def test_validate_purchase(client: TestClient):
         name_fr="Produit à adhésion",
         name_en="Product",
         available_online=False,
+        needs_validation=True,
     )
     await add_object_to_db(product_2)
     variant_to_validate = models_cdr.ProductVariant(

tests/test_cdr_result.py

@@ -106,6 +106,7 @@ async def init_objects():
         description_fr="Un Produit",
         description_en="A Product",
         available_online=False,
+        needs_validation=True,
     )
 
     global product2
@@ -117,6 +118,7 @@ async def init_objects():
         description_fr="Un Produit2",
         description_en="A Product2",
         available_online=False,
+        needs_validation=True,
     )
 
     global product3
@@ -128,6 +130,7 @@ async def init_objects():
         description_fr="Un Produit3",
         description_en="A Product3",
         available_online=False,
+        needs_validation=True,
     )
 
     global customdata_field1