CDR : allow edition and deletion during cdr (#808)

### Description

Please explain the changes you made here.

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary

Author: Malem38

app/modules/cdr/cruds_cdr.py

@@ -515,6 +515,18 @@ async def get_purchases_by_user_id_by_seller_id(
     return result.scalars().all()
 
 
+async def get_purchases_by_variant_id(
+    db: AsyncSession,
+    product_variant_id: UUID,
+) -> Sequence[models_cdr.Purchase]:
+    result = await db.execute(
+        select(models_cdr.Purchase).where(
+            models_cdr.Purchase.product_variant_id == product_variant_id,
+        ),
+    )
+    return result.scalars().all()
+
+
 def create_purchase(
     db: AsyncSession,
     purchase: models_cdr.Purchase,

app/modules/cdr/endpoints_cdr.py

@@ -837,21 +837,19 @@ async def update_product(
         user,
         db=db,
     )
-    status = await get_core_data(schemas_cdr.Status, db)
-    db_product = await check_request_consistency(
+    await check_request_consistency(
         db=db,
         seller_id=seller_id,
         product_id=product_id,
     )
-    if status.status in [
-        CdrStatus.onsite,
-        CdrStatus.closed,
-    ] or (
-        db_product and status.status == CdrStatus.online and db_product.available_online
-    ):
+    variants = await cruds_cdr.get_product_variants(
+        db=db,
+        product_id=product_id,
+    )
+    if variants and product.related_membership:
         raise HTTPException(
             status_code=403,
-            detail="This product can't be edited now. Please try creating a new product.",
+            detail="You can't link or unlink this product to a membership if it has variant in it.",
         )
 
     await cruds_cdr.update_product(
@@ -901,22 +899,13 @@ async def delete_product(
         user,
         db=db,
     )
-    status = await get_core_data(schemas_cdr.Status, db)
-    db_product = await check_request_consistency(
+
+    await check_request_consistency(
         db=db,
         seller_id=seller_id,
         product_id=product_id,
     )
-    if status.status in [
-        CdrStatus.onsite,
-        CdrStatus.closed,
-    ] or (
-        db_product and status.status == CdrStatus.online and db_product.available_online
-    ):
-        raise HTTPException(
-            status_code=403,
-            detail="You can't delete a product once CDR has started.",
-        )
+
     variants = await cruds_cdr.get_product_variants(
         db=db,
         product_id=product_id,
@@ -1050,29 +1039,31 @@ async def update_product_variant(
         user,
         db=db,
     )
-    status = await get_core_data(schemas_cdr.Status, db)
+
     db_product = await check_request_consistency(
         db=db,
         seller_id=seller_id,
         product_id=product_id,
         variant_id=variant_id,
     )
-    if product_variant.model_fields_set != {
-        "enabled",
-    }:
-        if status.status in [
-            CdrStatus.onsite,
-            CdrStatus.closed,
-        ] or (
-            db_product
-            and status.status == CdrStatus.online
-            and db_product.available_online
-        ):
-            # We allow to update the enabled field even if CDR is onsite or closed
-            raise HTTPException(
-                status_code=403,
-                detail="This product can't be edited now. Please try creating a new product.",
-            )
+    purchases = await cruds_cdr.get_purchases_by_variant_id(
+        db=db,
+        product_variant_id=variant_id,
+    )
+    if purchases and "price" in product_variant.model_fields_set:
+        raise HTTPException(
+            status_code=403,
+            detail="You can't edit the price of this variant because it has already been purchased.",
+        )
+    if (
+        purchases
+        and "related_membership_added_duration" in product_variant.model_fields_set
+    ):
+        raise HTTPException(
+            status_code=403,
+            detail="You can't edit the membership added duration of this variant because it has already been purchased.",
+        )
+
     if (
         db_product
         and not db_product.related_membership
@@ -1130,22 +1121,21 @@ async def delete_product_variant(
         user,
         db=db,
     )
-    status = await get_core_data(schemas_cdr.Status, db)
-    db_product = await check_request_consistency(
+    await check_request_consistency(
         db=db,
         seller_id=seller_id,
         product_id=product_id,
         variant_id=variant_id,
     )
-    if status.status in [
-        CdrStatus.onsite,
-        CdrStatus.closed,
-    ] or (
-        db_product and status.status == CdrStatus.online and db_product.available_online
-    ):
+
+    purchases = await cruds_cdr.get_purchases_by_variant_id(
+        db=db,
+        product_variant_id=variant_id,
+    )
+    if purchases:
         raise HTTPException(
             status_code=403,
-            detail="You can't delete a product once CDR has started.",
+            detail="You can't delete this variant because it has been purchased.",
         )
     await cruds_cdr.delete_allowed_curriculums(db=db, variant_id=variant_id)
     await cruds_cdr.delete_product_variant(

tests/test_cdr.py

@@ -1456,7 +1456,7 @@ def test_patch_product_variant_cdr_started(client: TestClient):
     response = client.patch(
         f"/cdr/sellers/{seller.id!s}/products/{product.id!s}/variants/{variant.id}/",
         json={
-            "name_fr": "Variante modifiée",
+            "price": "700",
         },
         headers={"Authorization": f"Bearer {token_bde}"},
     )
@@ -2124,17 +2124,6 @@ def test_create_product_closed(client: TestClient):
     assert response.status_code == 403
 
 
-def test_patch_product_closed(client: TestClient):
-    response = client.patch(
-        f"/cdr/sellers/{seller.id!s}/products/{product.id}/",
-        json={
-            "name_fr": "Produit modifié",
-        },
-        headers={"Authorization": f"Bearer {token_bde}"},
-    )
-    assert response.status_code == 403
-
-
 def test_create_product_variant_closed(client: TestClient):
     response = client.post(
         f"/cdr/sellers/{seller.id!s}/products/{product.id!s}/variants/",