Allow read access even when last ToS are refused (#738)

Allow read (GET) to:
* wallet (especially to display the balance)
* the device information

Author: Marc-Andrieu

app/core/myeclpay/endpoints_myeclpay.py

@@ -1231,7 +1231,7 @@ async def get_user_devices(
         user_id=user.id,
         db=db,
     )
-    if user_payment is None or not is_user_latest_tos_signed(user_payment):
+    if user_payment is None:
         raise HTTPException(
             status_code=400,
             detail="User is not registered for MyECL Pay",
@@ -1263,30 +1263,30 @@ async def get_user_device(
         user_id=user.id,
         db=db,
     )
-    if user_payment is None or not is_user_latest_tos_signed(user_payment):
+    if user_payment is None:
         raise HTTPException(
             status_code=400,
             detail="User is not registered for MyECL Pay",
         )
 
-    wallet_devices = await cruds_myeclpay.get_wallet_device(
+    wallet_device = await cruds_myeclpay.get_wallet_device(
         wallet_device_id=wallet_device_id,
         db=db,
     )
 
-    if wallet_devices is None:
+    if wallet_device is None:
         raise HTTPException(
             status_code=404,
             detail="Wallet device does not exist",
         )
 
-    if wallet_devices.wallet_id != user_payment.wallet_id:
+    if wallet_device.wallet_id != user_payment.wallet_id:
         raise HTTPException(
             status_code=400,
             detail="Wallet device does not belong to the user",
         )
 
-    return wallet_devices
+    return wallet_device
 
 
 @router.get(
@@ -1308,7 +1308,7 @@ async def get_user_wallet(
         user_id=user.id,
         db=db,
     )
-    if user_payment is None or not is_user_latest_tos_signed(user_payment):
+    if user_payment is None:
         raise HTTPException(
             status_code=400,
             detail="User is not registered for MyECL Pay",