Redirect to calypsso pages after confirmation (#722)

### Description

After an operation that involve opening an url, redirect to a nice
Success or Error page from CalypSSO instead of returning directly a
string.

For errors, this pull request only redirect for errors that are expected
to happen.
For example clicking an activation link a second times, or an expired
link should show a nice error. On the other hand we can expect that
opening a link with an nonexisting token should never happen under
normal conditions.

Author: armanddidierjean

app/core/myeclpay/endpoints_myeclpay.py

@@ -321,6 +321,7 @@ async def init_transfer_structure_manager(
 async def confirm_structure_manager_transfer(
     token: str,
     db: AsyncSession = Depends(get_db),
+    settings: Settings = Depends(get_settings),
 ):
     """
     Update a manager for an association
@@ -385,6 +386,13 @@ async def confirm_structure_manager_transfer(
             )
     await db.commit()
 
+    return RedirectResponse(
+        url=settings.CLIENT_URL
+        + calypsso.get_message_relative_url(
+            message_type=calypsso.TypeMessage.myeclpay_structure_transfer_success,
+        ),
+    )
+
 
 @router.post(
     "/myeclpay/structures/{structure_id}/stores",
@@ -1379,6 +1387,7 @@ async def activate_user_device(
     token: str,
     db: AsyncSession = Depends(get_db),
     notification_tool: NotificationTool = Depends(get_notification_tool),
+    settings: Settings = Depends(get_settings),
 ):
     """
     Activate a wallet device
@@ -1396,9 +1405,11 @@ async def activate_user_device(
         )
 
     if wallet_device.status != WalletDeviceStatus.INACTIVE:
-        raise HTTPException(
-            status_code=400,
-            detail="Wallet device is already activated or revoked",
+        return RedirectResponse(
+            url=settings.CLIENT_URL
+            + calypsso.get_message_relative_url(
+                message_type=calypsso.TypeMessage.myeclpay_wallet_device_already_activated_or_revoked,
+            ),
         )
 
     await cruds_myeclpay.update_wallet_device_status(
@@ -1437,7 +1448,12 @@ async def activate_user_device(
     else:
         raise UnexpectedError(f"Activated wallet device {wallet_device.id} has no user")  # noqa: TRY003
 
-    return "Wallet device activated"
+    return RedirectResponse(
+        url=settings.CLIENT_URL
+        + calypsso.get_message_relative_url(
+            message_type=calypsso.TypeMessage.myeclpay_wallet_device_activation_success,
+        ),
+    )
 
 
 @router.post(

app/core/users/endpoints_users.py

@@ -15,7 +15,7 @@
     Query,
     UploadFile,
 )
-from fastapi.responses import FileResponse
+from fastapi.responses import FileResponse, RedirectResponse
 from fastapi.templating import Jinja2Templates
 from sqlalchemy.exc import IntegrityError
 from sqlalchemy.ext.asyncio import AsyncSession
@@ -346,6 +346,7 @@ async def activate_user(
     user: schemas_users.CoreUserActivateRequest,
     db: AsyncSession = Depends(get_db),
     request_id: str = Depends(get_request_id),
+    settings: Settings = Depends(get_settings),
 ):
     """
     Activate the previously created account.
@@ -364,7 +365,12 @@ async def activate_user(
 
     # We need to make sure the unconfirmed user is still valid
     if unconfirmed_user.expire_on < datetime.now(UTC):
-        raise HTTPException(status_code=400, detail="Expired activation token")
+        return RedirectResponse(
+            url=settings.CLIENT_URL
+            + calypsso.get_message_relative_url(
+                message_type=calypsso.TypeMessage.token_expired,
+            ),
+        )
 
     # An account with the same email may exist if:
     # - the user called two times the user creation endpoints and got two activation token
@@ -547,6 +553,7 @@ async def recover_user(
 async def reset_password(
     reset_password_request: schemas_users.ResetPasswordRequest,
     db: AsyncSession = Depends(get_db),
+    settings: Settings = Depends(get_settings),
 ):
     """
     Reset the user password, using a **reset_token** provided by `/users/recover` endpoint.
@@ -560,7 +567,12 @@ async def reset_password(
 
     # We need to make sure the unconfirmed user is still valid
     if recover_request.expire_on < datetime.now(UTC):
-        raise HTTPException(status_code=400, detail="Expired reset token")
+        return RedirectResponse(
+            url=settings.CLIENT_URL
+            + calypsso.get_message_relative_url(
+                message_type=calypsso.TypeMessage.token_expired,
+            ),
+        )
 
     new_password_hash = security.get_password_hash(reset_password_request.new_password)
     await cruds_users.update_user_password_by_id(

tests/test_myeclpay.py

@@ -1157,9 +1157,13 @@ async def test_create_and_activate_user_device(
     response = client.get(
         f"/myeclpay/devices/activate?token={UNIQUE_TOKEN}",
         headers={"Authorization": f"Bearer {ecl_user_access_token}"},
+        follow_redirects=False,
+    )
+    assert response.status_code == 307
+    assert response.next_request is not None
+    assert str(response.next_request.url).endswith(
+        "calypsso/message?type=myeclpay_wallet_device_activation_success",
     )
-    assert response.status_code == 200
-    assert response.json() == "Wallet device activated"
 
 
 async def test_activate_non_existing_device(
@@ -1179,9 +1183,13 @@ async def test_activate_already_activated_device(
     response = client.get(
         "/myeclpay/devices/activate?token=activation_token_ecl_user_wallet_device",
         headers={"Authorization": f"Bearer {ecl_user_access_token}"},
+        follow_redirects=False,
+    )
+    assert response.status_code == 307
+    assert response.next_request is not None
+    assert str(response.next_request.url).endswith(
+        "calypsso/message?type=myeclpay_wallet_device_already_activated_or_revoked",
     )
-    assert response.status_code == 400
-    assert response.json()["detail"] == "Wallet device is already activated or revoked"
 
 
 async def test_revoke_user_device_unregistered_user(