Fix sending websocket message when editing cdr user membership (#812)

Author: armanddidierjean

app/modules/cdr/endpoints_cdr.py

@@ -46,6 +46,7 @@
     is_user_in_a_seller_group,
     validate_payment,
 )
+from app.types.exceptions import ObjectExpectedInDbNotFoundError
 from app.types.module import Module
 from app.types.websocket import (
     HyperionWebsocketsRoom,
@@ -303,17 +304,30 @@ async def update_cdr_user(
             detail="User not found.",
         )
 
-    curriculum = await cruds_cdr.get_cdr_user_curriculum(db, user_id)
+    curriculum_membership = await cruds_cdr.get_cdr_user_curriculum(db, user_id)
+    curriculum: schemas_cdr.CurriculumComplete | None = None
+    if curriculum_membership:
+        curriculum_db = await cruds_cdr.get_curriculum_by_id(
+            db=db,
+            curriculum_id=curriculum_membership.curriculum_id,
+        )
+        if curriculum_db is None:
+            raise ObjectExpectedInDbNotFoundError(
+                object_name="curriculum",
+                object_id=curriculum_membership.curriculum_id,
+            )
+        curriculum = schemas_cdr.CurriculumComplete(
+            id=curriculum_db.id,
+            name=curriculum_db.name,
+        )
 
     cdr_status = await get_core_data(schemas_cdr.Status, db)
     if cdr_status.status == CdrStatus.onsite:
         try:
             await ws_manager.send_message_to_room(
                 message=schemas_cdr.UpdateUserWSMessageModel(
                     data=schemas_cdr.CdrUser(
-                        curriculum=schemas_cdr.CurriculumComplete(
-                            **curriculum.__dict__,
-                        ),
+                        curriculum=curriculum,
                         school_id=user_db.school_id,
                         account_type=user_db.account_type,
                         name=user_db.name,

app/types/exceptions.py

@@ -1,4 +1,5 @@
 from typing import Any
+from uuid import UUID
 
 from fastapi import HTTPException
 
@@ -210,3 +211,17 @@ def __init__(self, subfolder: str):
         super().__init__(
             f"Invalid S3 subfolder: {subfolder} - it should not contain '/'",
         )
+
+
+class ObjectExpectedInDbNotFoundError(Exception):
+    """
+    This exception should be raised when an object is expected to be found in database, but the select crud return None.
+    It may be used when selecting an object to load relationship just after this creation, or selecting an object we know existing because of a foreign key.
+
+    This should never happen. Raising this exception should lead to a logged 500 internal server error.
+    """
+
+    def __init__(self, object_name: str, object_id: str | UUID):
+        super().__init__(
+            f"Object {object_name} with id {object_id} was expected in database but not found",
+        )